Date: Mon, 27 May 2019 19:57:25 +0000 From: Alexey Dokuchaev <danfe@freebsd.org> To: rgrimes@freebsd.org Cc: Konstantin Belousov <kostikbel@gmail.com>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r232071 - head/sys/vm Message-ID: <20190527195725.GA80681@FreeBSD.org> In-Reply-To: <201905271421.x4RELOfH011064@gndrsh.dnsmgr.net> References: <20190527112155.GZ2748@kib.kiev.ua> <201905271421.x4RELOfH011064@gndrsh.dnsmgr.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, May 27, 2019 at 07:21:24AM -0700, Rodney W. Grimes wrote: > ... > We as a project look bad by not having this minimal set of code > reviews in place for things that are coming from a source that is > frought with introducing bad change. We do *not* look bad because none of those warnings and errors suggested by (any) static analysis tools were ever passed without all the due checks by either the original committer, the last committer who touched the files, or opening a PR in less straight-forward cases. I have several potential issues in my queue from the last run which I might submit for the further analysis (via email or PR), but for now since I've published the full log (very noisy), let's see if it gets any traction on its own. Some people had contacted me off-the-list and expressed their interest. I'll revisit it in a few weeks to see if nagging developers and opening PRs is still needed, or the bugs are being voluntarily squished by responsible (and having proper domain-knowledge) parties. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190527195725.GA80681>