Date: Fri, 19 Sep 2025 16:25:42 +0100 From: Lexi Winter <ivy@freebsd.org> To: Colin Percival <cperciva@freebsd.org>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 6b5adf33873a - main - Include a pkg package in the pkgbase repo Message-ID: <aM119hwMe44CDbxm@amaryllis.le-fay.org> In-Reply-To: <aM1tRZ7O-AWG1ghZ@amaryllis.le-fay.org> References: <202509172239.58HMdOK9055924@gitrepo.freebsd.org> <aM1tRZ7O-AWG1ghZ@amaryllis.le-fay.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
Lexi Winter wrote in <aM1tRZ7O-AWG1ghZ@amaryllis.le-fay.org>:
> Colin Percival wrote in <202509172239.58HMdOK9055924@gitrepo.freebsd.org>:
> > Include a pkg package in the pkgbase repo
> >
> > -create-packages: .PHONY create-packages-world create-packages-kernel create-packages-source create-packages-sets
> > +create-packages: .PHONY create-packages-world create-packages-kernel create-packages-source package-pkg create-packages-sets
>
> please consider reverting this: it causes a normal source build to
> attempt to install software from ports as root, which is not right,
> and it means the base repository is polluted with a random package
> from ports, when it is supposed to only include the base system.
>
> if this is necessary for the release media, then it should at least
> be optional and enabled by a make option, not by default.
this also breaks the build if ${LOCALBASE} is set to a non-default
value: https://people.freebsd.org/~ivy/tmp/update-packages.log
if i'm reading this right, it seems like even if this works it will
build a new pkg package every time you build src, which roughly doubles
the time it takes me to build packages. that's going to slow down my
development workflow significantly, since i always update from packages
when testing changes.
i've reverted this locally for now so i can get some work done.
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
iHUEABYKAB0WIQSyjTg96lp3RifySyn1nT63mIK/YAUCaM118wAKCRD1nT63mIK/
YFDHAQDrHJOhHkojdEdnhLkDelASz1Cy9CPNeNdK/kUZoIdvewEA0mEZaTXLLcCB
Wqll/3ey3S/8jl4k0ig8lkK0gpAtoQA=
=tlZx
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?aM119hwMe44CDbxm>