Date: Tue, 19 Apr 2011 20:17:37 -0400 From: "J. Hellenthal" <jhell@DataIX.net> To: Bruce Cran <bruce@cran.org.uk>, freebsd-current@freebsd.org Subject: Re: Finding typos using codespell Message-ID: <20110420001737.GE2483@DataIX.net> In-Reply-To: <20110419122210.GL85668@acme.spoerlein.net> References: <20110419111500.GA16509@muon.cran.org.uk> <20110419122210.GL85668@acme.spoerlein.net>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Tue, Apr 19, 2011 at 02:22:10PM +0200, Ulrich Spörlein wrote: >On Tue, 19.04.2011 at 12:15:00 +0100, Bruce Cran wrote: >> There's a new tool that can be used to find spelling mistakes in code: codespell >> from http://www.politreco.com has already been used to find mistakes in both >> Linux and LLVM. I ran it on sys/ and it found lots of potential typos - the >> full diff (which I know does contain some incorrect changes) can be found at >> http://www.cran.org.uk/~brucec/freebsd/codespell_sys.diff . > >Needs manual review, but I think this is very useful for the spelling >nazi challenged among us :-) > >False positive, e.g.: > { >- struct ccb_immed_notify *inot; >+ struct ccb_immed_notify *into; > mpt_tgt_state_t *tgt; > >Cheers, >Uli As mentioned here already changes that I have noticed are: (Upper || lower case): inot -> into lsat -> last inbetween -> between ALOT -> A LOT boundry -> boundary "This one seems to have corrected itself." virtualY -> virtually ID -> DID lastr -> last *Any uuencoded file* This was just a review of the functional changes. The no-op changes I just filtered out of the patch to quickly catch the "Bad Thing" changes above. It might just be better to build a list of files with spelling errors and anyone with the next commit to any of those files just runs it through aspell/ispell or whatever they like rather than causing this much of a slush. All in all good find Bruce!. -- Regards, J. Hellenthal WWJD [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (FreeBSD) Comment: http://bit.ly/0x89D8547E iQEcBAEBAgAGBQJNriYhAAoJEJBXh4mJ2FR+WaQH/jYS1pF1kiL73zi1QlpfvjI2 7Vjtmpv2s91ih1URDvf5B+I+IpSiYvMreFhKeAJsBVUXyfILUtO1sSYUh06E2oHf sE6t9cD2q2BndVaXUXvgycYlvDO2r52vpIWqL7hiAufubTLnqNYNVIwYyL0lOuWR zPUxNLCb816iWkynS9vxKIW2hhYjX3Obw3d06rOQ3WRnjOTv8UVPYrw5GgcWdDvo WQetM0GCuhGBYTv64EioCuVnzpN+lbf+H2aoRjJlMeLVpTLigr7aZWlM+Ps1FgTh XRe2Ya5/ys3ZztXh778+RSGbMQWKxoADgcGbLmm5+16qMRkk5B9G7wFzvmN2pgU= =A3Z6 -----END PGP SIGNATURE-----help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20110420001737.GE2483>