Date: Fri, 8 Dec 2017 21:16:14 -0600 From: Kyle Evans <kevans@freebsd.org> To: Eitan Adler <eadler@freebsd.org> Cc: rgrimes@freebsd.org, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r326614 - in head: etc/mtree usr.bin usr.bin/sponge usr.bin/tee Message-ID: <CACNAnaHcXSdAxGFfo3P%2B-8e4KDZ=g-NSMwZ66Z4janNpkm%2Bjqg@mail.gmail.com> In-Reply-To: <CAF6rxgmexdxt7q1=9%2BNZoRAZmr%2BMHDdhtPZAcdw-DcjjhLPa=A@mail.gmail.com> References: <CAG6CVpUm5KZYox_yNgg59ZiAM45rKp-69PnpdJTCJt6PdMO8_Q@mail.gmail.com> <201712082011.vB8KBUsA068552@pdx.rh.CN85.dnsmgr.net> <CAF6rxgmexdxt7q1=9%2BNZoRAZmr%2BMHDdhtPZAcdw-DcjjhLPa=A@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Dec 8, 2017 8:07 PM, "Eitan Adler" <eadler@freebsd.org> wrote:
On 8 December 2017 at 12:11, Rodney W. Grimes
<freebsd@pdx.rh.cn85.dnsmgr.net> wrote:
> Ping, I have not seen this reverted and recommitted with a reasonable
> explination as to why this change is actually desired.
Sorry, work has been busy and as the crux was reverted it didn't feel
as urgent[0]. The answer is that shell scripts in scripts don't need
to be chmod +x to work. In fact most are not.
Of the tests I found from a simple search:
65 are chmod +x
84 are chmod -x
The entirety of the changed config is:
"chmod": {
"type": "chmod",
+ "exclude": "(/tests/)"
},
which simply disables this test during 'arc diff'.
+1 to this change, but I think it would've been worthy of its own commit. I
don't recall off-hand if it's ATF-specific or not- in that case, at least,
the scripts are merely being processed into atf-sh script for when it ends
up in /usr/tests.
It's probably worth double checking the non-ATF case to make sure -x won't
break their expected execution, though.
- Kyle Evans
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CACNAnaHcXSdAxGFfo3P%2B-8e4KDZ=g-NSMwZ66Z4janNpkm%2Bjqg>