Date: 14 Mar 2001 01:40:15 +0100 From: Dag-Erling Smorgrav <des@ofug.org> To: dannyman <dannyman@toldme.com> Cc: freebsd-security@FreeBSD.ORG Subject: Re: Sophos "idefetch" script Message-ID: <xzpr901yyhc.fsf@flood.ping.uio.no> In-Reply-To: dannyman's message of "Tue, 13 Mar 2001 16:10:17 -0800" References: <20010313151512.Q3500@dell.dannyland.org> <xzpvgpdz05t.fsf@flood.ping.uio.no> <20010313161017.Z3500@dell.dannyland.org>
next in thread | previous in thread | raw e-mail | index | archive | help
dannyman <dannyman@toldme.com> writes:
> Is this addendum to the script okay by you? ;)
Umm, the idea was actually to suggest an improvement on your own
script. If you don't like it, just ignore it.
1) it's conventional to use lowercase names for variables internal to
the script, and reserve uppercase names for variables passed from
the shell.
2) you should always take care to wrap variable references in double
quotes
3) you shouldn't redirect fetch's stderr to /dev/null, use -q to hide
the status messages
4) your for loop will break if one of the IDEs' name contains funny
characters; my while loop won't
5) you don't need to cd to ${idedir}, you can ask fetch to put the
files there for you - though that's mostly a matter of taste
DES
--
Dag-Erling Smorgrav - des@ofug.org
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-security" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?xzpr901yyhc.fsf>