Date: Sat, 06 Dec 2003 14:07:57 +0100 From: Matthias Andree <matthias.andree@gmx.de> To: FreeBSD-gnats-submit@FreeBSD.org, re@FreeBSD.org, portmgr@FreeBSD.org, portsmgr@FreeBSD.org Cc: dwcjr@FreeBSD.org Subject: ports/59990: [PATCH] net/samba: register popt dependency Message-ID: <E1AScA9-0005Qw-Dj@libertas.emma.line.org> Resent-Message-ID: <200312061540.hB6Fe3n1009416@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 59990 >Category: ports >Synopsis: [PATCH] net/samba: register popt dependency >Confidential: no >Severity: serious >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Sat Dec 06 07:40:02 PST 2003 >Closed-Date: >Last-Modified: >Originator: Matthias Andree >Release: FreeBSD 4.9-STABLE i386 >Organization: >Environment: System: FreeBSD libertas.emma.line.org 4.9-STABLE FreeBSD 4.9-STABLE #63: Sat Dec 6 13:32:32 CET >Description: This patch adds a LIB_DEPENDS line for popt. Please add this patch to the 5.2 ports and move the tag. re@ and portmgr@ are Cc'd -- please approve or reject. REASONS: 1. Samba's ./configure will automatically pull in the system popt if popt is installed when Samba (as port) is compiled, without registering it as a dependency. This means popt can later be removed without complaint, but this may break Samba. (Has been observed live on my system). 2. If Samba uses popt, we should use a system-wide shared object rather than letting Samba link against a local popt copy locally, to decrease the number of recompiles should there be a cricital popt bug discovered in the future. I am not aware of any such current issue, this is to increase maintainability. Port maintainer (dwcjr@FreeBSD.org) is also cc'd. Generated with FreeBSD Port Tools 0.50 >How-To-Repeat: >Fix: --- samba-2.2.8a.patch begins here --- diff -ruN --exclude=CVS /usr/ports/net/samba/Makefile /root/samba/Makefile --- /usr/ports/net/samba/Makefile Wed Nov 26 21:38:29 2003 +++ /root/samba/Makefile Sat Dec 6 13:43:30 2003 @@ -111,6 +111,8 @@ CONFIGURE_ARGS+= --with-msdfs .endif +LIB_DEPENDS+= popt.0:${PORTSDIR}/devel/popt + .if defined(WITH_LDAP) LIB_DEPENDS+= ldap.2:${PORTSDIR}/net/openldap20-client CONFIGURE_ARGS+= --with-ldapsam --- samba-2.2.8a.patch ends here --- >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?E1AScA9-0005Qw-Dj>