Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 23 Jan 2014 21:17:48 +0100
From:      Mateusz Guzik <mjguzik@gmail.com>
To:        "Andrey V. Elsukov" <ae@FreeBSD.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r261085 - head/sys/geom
Message-ID:  <20140123201748.GA26772@dft-labs.eu>
In-Reply-To: <201401231931.s0NJVHKS089308@svn.freebsd.org>
References:  <201401231931.s0NJVHKS089308@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Jan 23, 2014 at 07:31:17PM +0000, Andrey V. Elsukov wrote:
> @@ -122,7 +123,7 @@ geom_alloc_copyin(struct gctl_req *req, 
>  	void *ptr;
>  
>  	ptr = g_malloc(len, M_WAITOK);
> -	nreq->nerror = copyin(uaddr, ptr, len);
> +	req->nerror = copyin(uaddr, ptr, len);
>  	if (!req->nerror)
>  		return (ptr);
>  	if (ptr != NULL)

Is not this if (ptr != NULL) unnecesary?

-- 
Mateusz Guzik <mjguzik gmail.com>



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140123201748.GA26772>