Date: Wed, 18 Mar 2015 18:01:42 +0100 From: Alexandre Martins <alexandre.martins@stormshield.eu> To: 'freebsd-current' <freebsd-current@freebsd.org> Subject: Possible race in IPv6 Message-ID: <95157304.ieSUkydfeD@pc-alex>
index | next in thread | raw e-mail
[-- Attachment #1 --] Dear, I'm facing some crash around manipulations of IPv6 address. I already found that the commit 275593 will fix my issue. However, after some code review, i see a possible race in the function nd6_na_input: https://svnweb.freebsd.org/base/head/sys/netinet6/nd6_nbr.c?annotate=279676#l750 =-=-=-=-=-=-=-=-=-= if (ifa && (((struct in6_ifaddr *)ifa)->ia6_flags & IN6_IFF_TENTATIVE)) { ifa_free(ifa); nd6_dad_na_input(ifa); goto freeit; } =-=-=-=-=-=-=-=-=-= As you can see, the function drop its reference on the address and pass it to nd6_dad_na_input. It should be better to release the reference after the call. What about you? Regards -- Alexandre Martins STORMSHIELD [-- Attachment #2 --] 0 *H 01 0 + 0 *H 00n 0 *H 0H1 0 UFR10U STORMSHIELD1#0!U Stormshield Root Authority0 140904150710Z 240901150710Z0I1 0 UFR10U STORMSHIELD1$0"U Stormshield Users Authority0"0 *H 0 X6[t. D Uge0-2;h@eȻClΫp B# M,FY=.{ya{2πߢ 7 <d~O;ޅԋ&C 8ُ6@CXX>|abqenmI, O&'۰@%OhW& {52D%_8#f]G0ct y \ v0t0 U ml||uu4[ׁ0 U #0BgDaP0U 00U 0 `HB0 *H N9-؞>m-K!M-7zD6IZʾr>q? u ?xr6_'NջZ7]V\5Y&) )m@~^Qdp/H3ͦ` o⬋U,z,0Bdp!C2K8.r>0-1!C%3U2ϠMg~3 ͟wͲAZ&vF/BA$_ڀV! s7)=-nP> qH~g/Rs,PAJVm#QXJo */V|s Ŀj~y߽j 3]v3ƌqe`Y|HB3lC!^J2$4A`Z+( 7b{e˄wʈ<L=6[3`>IQF aiܝ ?:_yԊ / `00ޠ (0 *H 0I1 0 UFR10U STORMSHIELD1$0"U Stormshield Users Authority0 140904151038Z 150904151038Z0p1 0 UFR10U STORMSHIELD10U Alexandre MARTINS1/0- *H alexandre.martins@stormshield.eu0"0 *H 0 'l(bOx<yliĻT$ }C1#quQ^On^H"Ca9e 1`s +:Bu8xAIE<{H*Kb Қ$(dz EkUXfצ+돩T' xOחv9LOtrZߤʭŜʨc͈F 13/E;NV̓Xđ_QHt@J;F'` 'rregC 00 U H+R6"60 U #0ml||uu4[ׁ0 U 0 0U 0+U $0" alexandre.martins@stormshield.eu0 `HB0 U %0++0 *H G07 i֗^Qځ ;7 T8%M .Ӛɼ,K=^I_Y +0y@5*rԲ >7cb\+$%'|zenOA\Aη;ڋZA1?Tru13?>>/ٓyC ]#Lԉ.?<GΌ qNjU2k`?u;&)H4AXQº\ x*C9#55TR#+{d7Je^m100R0I1 0 UFR10U STORMSHIELD1$0"U Stormshield Users Authority (0 + 0 *H 1 *H 0 *H 1 150318170142Z0# *H 1 qd P4- 0( *H 100 `He0 *H 0 *H @~+4;(xZRMT3Ϝ?8+; -2=3ϗid ilgB)8 ٘ҋݡ\4"PK) G]^* pET/y)?|;EK cQIqNG0'J 4 |`^_ T(:)~.b Wmz(~x:$G @sԯ뾖(QK5r-Ehelp
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?95157304.ieSUkydfeD>