Date: Fri, 18 Jan 2019 10:32:36 -0800 From: Cy Schubert <Cy.Schubert@cschubert.com> To: Eugene Grosbein <eugen@grosbein.net> Cc: Maxim Sobolev <sobomax@freebsd.org>, "Conrad E. Meyer" <cem@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r343118 - in head/usr.sbin: . trim Message-ID: <C2574E91-3C15-4A2A-9817-C60B5B90BDA3@cschubert.com> In-Reply-To: <5C41EC89.9000900@grosbein.net> References: <201901181254.x0ICsbBb076360@slippy.cwsent.com> <5C41EC89.9000900@grosbein.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On January 18, 2019 7:11:05 AM PST, Eugene Grosbein <eugen@grosbein.net> wrote: >On 18.01.2019 19:54, Cy Schubert wrote: > >> In message <81bb343b-ad8a-371d-d94f-f72c8dbce754@grosbein.net>, >Eugene >> Grosbein >> writes: >>> 18.01.2019 5:25, Maxim Sobolev wrote: >>> >>>> Using usr.sbin/trim as an example. >>> >>> We still lack a command usable at installation stage (escape to >shell) to tri >>> m a device or partition >>> dedicated to ZFS Cache/ZFS Intention Log/zvol any other use when >ports/packag >>> es are not yet available. >> >> OK, I will put a review together for dd. >> >> Do you realize that what you just said? Your statement is >inconsistent >> with where trim is installed? Then it should have been installed in >> /sbin not where you put it. I don't want to start yet another >bikeshed >> arguing the merits of this or that -- I'm intentionally being vague >> here because I really don't want to stat a different bikeshed thread. > >> But suffice it to say, dd is the place for it because it lives in >/bin >> and dd is already included in /rescue. > >Modern FreeBSD installation media have usr/bin and usr/sbin ready for >shell session >as they contain live system. I'm not against dd conv=trim but it has >different usage pattern >and it is not easy replacement for trim(8). What do you not understand? We do not want it in base without a proper review. This second attempt at commit without a proper review is IMO disrespectful. Remove it now and submit a proper review. -- Pardon the typos and autocorrect, small keyboard in use. Cheers, Cy Schubert <Cy.Schubert@cschubert.com> FreeBSD UNIX: <cy@FreeBSD.org> Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?C2574E91-3C15-4A2A-9817-C60B5B90BDA3>