Date: Fri, 19 Sep 2014 11:35:35 -0600 From: Will Andrews <will@firepipe.net> To: John Baldwin <jhb@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, "src-committers@FreeBSD.org" <src-committers@freebsd.org>, Steven Hartland <killing@multiplay.co.uk> Subject: Re: svn commit: r271788 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs Message-ID: <CADBaqmjTpvXeQUg=gO89xdW-n6afmtFnsFtZAMvs%2B4gXj_tYPw@mail.gmail.com> In-Reply-To: <11362806.9nSfhFyLDg@ralph.baldwin.cx> References: <201409181655.s8IGtgft042984@svn.freebsd.org> <5783417ED470465B9C816FCA02B3690D@multiplay.co.uk> <11362806.9nSfhFyLDg@ralph.baldwin.cx>
next in thread | previous in thread | raw e-mail | index | archive | help
I found that neither TUNABLE_INT nor CTLFLAG_RWTUN work with this particular implementation of the tunable, so there is a regression that needs to be fixed (i.e. vfs.zfs.debug_flags always comes up 0 no matter what's in loader.conf). I believe it's limited to this particular tunable, however, because I tested another SYSCTL_PROC that had CTLFLAG_TUN set and it worked. --Will. On Fri, Sep 19, 2014 at 10:34 AM, John Baldwin <jhb@freebsd.org> wrote: > On Thursday, September 18, 2014 06:37:28 PM Steven Hartland wrote: >> You don't need a seperate TUNABLE_INT declations any more since the >> excellent SYSCTL refactor. > > That is my fault. I wasn't certain if SYSCTL_PROC() would work correctly when > Will asked me on IRC, but it seems it does so long as the tunable type is one > it knows how to parse (e.g. CTLTYPE_INT). If your sysctl wants a "blob" > (CTLTYPE_OPAQUE or the like), then you still need your own tunable fetching > handler. > > -- > John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CADBaqmjTpvXeQUg=gO89xdW-n6afmtFnsFtZAMvs%2B4gXj_tYPw>