Date: Sat, 23 Aug 2025 15:54:04 -0700 From: Mark Millard <marklmi@yahoo.com> To: Cy Schubert <Cy.Schubert@cschubert.com>, dev-commits-src-main@freebsd.org Subject: Re: git: 1685192ea1fa - main - hkbd: remove erorr detection in KDSKBSTATE ioctl Message-ID: <4F3E0260-9D82-424A-85D3-A068B9AF5F03@yahoo.com> References: <4F3E0260-9D82-424A-85D3-A068B9AF5F03.ref@yahoo.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Cy Schubert <Cy.Schubert_at_cschubert.com> wrote on
Date: Sat, 23 Aug 2025 17:10:11 UTC :
> . . .
>
> My machines running X (laptops),
>
> - the right mouse key no longer works under X, I can no longer use X,
> - the caps-lock light will not display under X
> - on the text console works, X does not.
>
> The three commits related have bee reverted locally, functionality has
> returned.
Could you list hashes for what you are referring to?
The 2 (not 3) that I know of for what was trying to be fixed
were:
• git: 1685192ea1fa - main - hkbd: remove erorr detection in KDSKBSTATE ioctl ShengYi Hung
. . .
• git: 6ea7e1f92882 - main - hkbd: fix compliation error for GENERIC ShengYi Hung
There is for the first of those:
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=288968
https://reviews.freebsd.org/D52101
(If you have appropriate notes for such places, feel
free to add them.)
The second just removed a layer of ()'s in a DPRINT:
https://reviews.freebsd.org/D52135
So far as I know, any change predating these 2 was not
part of the intended fix to already existing behavior.
===
Mark Millard
marklmi at yahoo.com
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4F3E0260-9D82-424A-85D3-A068B9AF5F03>