Date: Thu, 04 Sep 2014 11:53:27 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 191562] [new port] sysutils/rundeck Rundeck - remote node orchestration server Message-ID: <bug-191562-13-7PlWj8gA8s@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-191562-13@https.bugs.freebsd.org/bugzilla/> References: <bug-191562-13@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=191562 --- Comment #9 from John Marino <marino@FreeBSD.org> --- Quick review: I guess nothing is wrong with users, I see now it's a substition. However: Issue 1) Please respect 80-column limits. Use "\" to wrap lines. I see a couple of places this is needed. Issue 2) regarding this code: +.include <bsd.port.pre.mk> + +do-install: + ${MKDIR} ${STAGEDIR}${DATADIR} ${STAGEDIR}${RUNDECK_HOME}/server/lib + ${INSTALL_DATA} ${DISTDIR}/${DIST_SUBDIR}/${DISTNAME}${EXTRACT_SUFX} ${STAGEDIR}${DATADIR}/${PORTNAME}-launcher${EXTRACT_SUFX} + +.include <bsd.port.post.mk> Question 2A) Why is <pre> and <post> needed here? Request 2B) Please replace ${PORTNAME} with "rundeck". If I changed the name the port, the do-install would break. I know that *TONS* of people do exactly this and I think it's outright wrong. If you use jenkins, that's fine, but attach the log that proves this builds cleanly. -- You are receiving this mail because: You are the assignee for the bug.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-191562-13-7PlWj8gA8s>