Date: Fri, 10 Jul 2015 21:30:19 +0200 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: "Matthew D. Fuller" <fullermd@over-yonder.net> Cc: =?iso-8859-1?Q?Jos=E9_Garc=EDa?= Juanino <jjuanino@gmail.com>, freebsd-geom@freebsd.org Subject: Re: geli panics my system after suspend-resume: g_eli_orphan_spoil_assert() called for cd0.eli Message-ID: <20150710193018.GA1270@garage.freebsd.pl> In-Reply-To: <20150702200109.GC50491@over-yonder.net> References: <CAAVO5%2BLR9MfHvt0tR5G4FyXKRt_hzkR3ZKUxvEA8Z%2BjWuEFq3g@mail.gmail.com> <20150613224602.GB1733@over-yonder.net> <CAAVO5%2BJTeZBqLZmd5t_riNmChgH8YH76DurJ_TUumFfgnVvpZg@mail.gmail.com> <20150615060128.GC1733@over-yonder.net> <20150629013011.GN50491@over-yonder.net> <20150701154233.GA1456@garage.freebsd.pl> <20150701193027.GT50491@over-yonder.net> <CAAVO5%2BK4LjjdMStpeOCDu9NH_u%2BJT48=%2BgKVycocGuuPqfUNoA@mail.gmail.com> <20150702094909.GA1186@garage.freebsd.pl> <20150702200109.GC50491@over-yonder.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--YZ5djTAD1cGYuMQK Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 02, 2015 at 03:01:09PM -0500, Matthew D. Fuller wrote: > On Thu, Jul 02, 2015 at 11:49:10AM +0200 I heard the voice of > Pawel Jakub Dawidek, and lo! it spake thus: > >=20 > > With g_media_changed() we can get spoil event even if we hold > > provider exclusively open. Your patch, Matthew, is correct, but > > could you also update the comment there to take into account > > g_media_changed() addition? >=20 > Sure, you mean replacing the comment saying spoiling can't happen? > Something like: >=20 > Index: g_eli.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- g_eli.c (revision 285057) > +++ g_eli.c (working copy) > @@ -730,10 +730,10 @@ > sc =3D malloc(sizeof(*sc), M_ELI, M_WAITOK | M_ZERO); > gp->start =3D g_eli_start; > /* > - * Spoiling cannot happen actually, because we keep provider open for > - * writing all the time or provider is read-only. > + * Spoiling can happen even though we have the provider open > + * exclusively, e.g. through media change events. > */ > - gp->spoiled =3D g_eli_orphan_spoil_assert; > + gp->spoiled =3D g_eli_orphan; > gp->orphan =3D g_eli_orphan; > gp->dumpconf =3D g_eli_dumpconf; > /* Committed, thanks! --=20 Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://mobter.com --YZ5djTAD1cGYuMQK Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCgAGBQJVoB1KAAoJEJVLhSuxKFt1VHIQAKLkkjO10kTMFXOW9aX9bMW9 OhCHKsJbk9a5+mlD9oXfaDVgv2ZcA67w8RejaVZ9EuNO6ArGZUiRcjxgh8AdFFAA H0NlGZcqvvYtNXrHISY2/DjWIVlIK2QK1IfjAis+vWSwztDmHTrWZLN0rzCNqtkb SEw4asXc20doMJMcNM8qAch/XeT6ZIz2pJm4VGi9Hw+68RWfyjudb2XZUCYy+o0U HHmtuThDyG2Hu9bo3QgtXtuwXGmSxGHUT0SR9VMhywNXtOFEmRrYYljROMy20a++ 34BHZzmPCG06jrQ+h3hpB/M77NCQKOqSfsNsiDhbwXtFNbpIvBrCvsJScImQy4sJ XsV7kgMmCdkWRbO+Bhl9awPd6pRRAye77/zbCcJG3jbgzDTd0HjFq5+BVWC99A56 60XLIbiBqhXkKhfJyeuMdXg8Tb/5VFKZZAsqbaRfupMvHAT9stvT9lJiOqHZ/vV5 o2KDpwDjNBPQXpklZNia7IYUDi7wfbdv+YRC8MTnmbi9DkXJ5QgjQXLy2Kmlpsfc aSg69wUiXecCe7tI16n/6/aS7+Wh97AJMrTX2tR04ezToES2mYWVNRinrx15HRUl wbHPEaeBzBjPAS5oxWhfOiPhypRje+TSIFZ10LpI9ZkHdPldHWSXvmOqIMScHIwK /Fg/FvyYtmriD7lb2guj =6sFX -----END PGP SIGNATURE----- --YZ5djTAD1cGYuMQK--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150710193018.GA1270>