Date: Mon, 7 Jun 2010 22:07:43 +0200 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: Randall Stewart <rrs@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r208876 - head/sys/netinet Message-ID: <20100607200743.GB4468@garage.freebsd.pl> In-Reply-To: <201006061611.o56GBHbE089883@svn.freebsd.org> References: <201006061611.o56GBHbE089883@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--+pHx0qQiF2pBVqBT Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jun 06, 2010 at 04:11:17PM +0000, Randall Stewart wrote: > Author: rrs > Date: Sun Jun 6 16:11:16 2010 > New Revision: 208876 > URL: http://svn.freebsd.org/changeset/base/208876 >=20 > Log: > 1) Further enhance the INVARIANT lock validation (no locks) are > held by checking the create and inp locks as well. [...] > + if (mtx_owned(&inp->inp_create_mtx)) { > + panic("Own create lock on inp"); > + } > + if (mtx_owned(&inp->inp_mtx)) { > + panic("Own inp lock on inp"); > + } If you replace this with: mtx_assert(&inp->inp_create_mtx, MA_NOTOWNED); mtx_assert(&inp->inp_mtx, MA_NOTOWNED); But the kernel has to be compiled with INVARIANTS to make it work. --=20 Pawel Jakub Dawidek http://www.wheelsystems.com pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --+pHx0qQiF2pBVqBT Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iEYEARECAAYFAkwNUY8ACgkQForvXbEpPzQLJQCgnChrTlQpi4UdAyy6MwIxuaJY qycAoMCM401xg8zGoSicT6vawOWvAvRo =whM3 -----END PGP SIGNATURE----- --+pHx0qQiF2pBVqBT--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100607200743.GB4468>