Date: Wed, 21 Aug 2013 09:27:32 -0700 From: Jason Helfman <jgh@FreeBSD.org> To: marino@freebsd.org Cc: "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>, Alexey Dokuchaev <danfe@freebsd.org>, "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>, "ports-committers@freebsd.org" <ports-committers@freebsd.org>, Jason Helfman <jgh@freebsd.org>, Andrej Zverev <az@freebsd.org> Subject: Re: svn commit: r325041 - head/japanese/eb Message-ID: <CAMuy=%2Birq4NiMAwcP3n5-J5RC%2BWGieVmKDp_ksNvYKkLV-hAUg@mail.gmail.com> In-Reply-To: <5214E45B.4030103@marino.st> References: <201308201148.r7KBmYcU083251@svn.freebsd.org> <521359E7.2020008@marino.st> <CAD5bB%2BiA3HQ=dHmE5tjkEzcD88oAeBU4nvEqjjNmbjg=ix1P3Q@mail.gmail.com> <52135BDE.9070600@marino.st> <CAD5bB%2BhVqd-is=F2_EteSaH-mF0L45K4MmO2EU6vRaU1f2P2GA@mail.gmail.com> <20130821012043.GA40499@FreeBSD.org> <CAMuy=%2BjagDOn%2BeuFXxgBGTSuZaJcWQYR1ueOQATsvOuQY6VFFg@mail.gmail.com> <CAD5bB%2Bi3DWp9LQ=LW%2BzmNeT5-TNNPuvnN5C6%2BVaP%2B23aCDNOFw@mail.gmail.com> <CAMuy=%2Bi%2Bu1nfRNVU2F9AQ_eDvgpJya5u5mKZVDKtf=bNRXhYww@mail.gmail.com> <5214E45B.4030103@marino.st>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Aug 21, 2013 at 9:01 AM, John Marino <freebsd.contact@marino.st>wrote: > On 8/21/2013 17:58, Jason Helfman wrote: > > I thought I was making that clear. > > The PR shouldn't have been committed as is, so it is for the committer > > to resolve the issue. > > To be fair, while I believe there is an issue, I haven't proven it yet. > I also took over the PR, so now it's my responsibility. > > Regards, > John > > Fair enough. What this is doing though is making gettext a build dependency regardless if NLS is selected or not. (nls disabled here) $ make -V PORT_OPTIONS DOCS EXAMPLES IPV6 $ make -V USES gettext perl5 (nls enabled here) $ make -V PORT_OPTIONS DOCS EXAMPLES IPV6 NLS $ make -V USES gettext perl5 However the port doesn't disable NLS if it is not selected. It should conditionally add gettext, as you've pointed out, Unless of course it requires gettext regardless, which I have seen as well. I did built it though, and it looks like it needs gettext regardless, and it does break. http://meatwad.mouf.net/rubick/poudriere/logs/bulk/91amd64-jgh/latest/logs/errors/ja-eb-4.4.3.log And this log is with --disable-nls http://meatwad.mouf.net/rubick/poudriere/logs/bulk/91amd64-jgh/latest/logs/errors/ja-eb-4.4.3.log Sounds like an upstream bug, and when or if ever fixed, uses can be fixed to be conditional. -jgh -- Jason Helfman | FreeBSD Committer jgh@FreeBSD.org | http://people.freebsd.org/~jgh | The Power to Serve
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAMuy=%2Birq4NiMAwcP3n5-J5RC%2BWGieVmKDp_ksNvYKkLV-hAUg>