Date: Mon, 16 Apr 2012 03:09:36 +0200 (CEST) From: Gerald Pfeifer <gerald@pfeifer.com> To: Michael Scheidell <scheidell@FreeBSD.org> Cc: cvs-ports@FreeBSD.org, ports-committers@FreeBSD.org, cvs-all@FreeBSD.org, Pawel Pekala <pawel@FreeBSD.org> Subject: Re: cvs commit: ports/deskutils/cairo-dock-plugins Makefile distinfo ports/deskutils/cairo-dock-plugins/files patch-CDBashApplet.sh patch-Doncky-data-nvidia-config patch-GMenu-applet-menu patch-Network-Monitor-data-access-point patch-Network-Monitor-data-wifi patch-System-Monitor-data-nvidia-config patch-System-Monitor.conf.in patch-applet-appli-finder.c ... Message-ID: <alpine.LNX.2.00.1204160306180.2457@gerinyyl.fvgr> In-Reply-To: <4F8AB5C1.9030405@FreeBSD.org> References: <201204142151.q3ELpGFS087738@repoman.freebsd.org> <20120415132903.10f75d1f@FreeBSD.org> <4F8AB5C1.9030405@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 15 Apr 2012, Michael Scheidell wrote: >> This will break when LOCALBASE != /usr/local and it's user-settable >> variable as documented in ports(7). And two small questions: >> - could some of this be better solved by using REINPLACE_CMD ? >> - there's a lot bash scripts, shouldn't be there RUN_DEPENDS+= bash ? > let me ping the previous committer gerald@ and see if he had any > discussions on this. his commit was about 7 days ago, and I have > searched the archives and don't see that any similar discussions took > place last week. Yes, I did suggest to the maintainer that he approaches upstream to find a better solution rather than hardcoding those paths in several places. That update of his was a clear improvement, however, so I did commit it without waiting for perfection. > I will also ping (without cvs-* and private groups) maintainer > fidaj@ukr.net (I am sure he would welcome patches and a pr.. he > seems to be very active with updates to this port) I found him very responsive and helpful and a pleasure to work with. So whatever further notes you guys have, let him know and I am sure he will try to honor them. Gerald
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?alpine.LNX.2.00.1204160306180.2457>