Date: Tue, 13 Nov 2018 09:43:46 +0000 From: Max Brazhnikov <makc@freebsd.org> To: mat@freebsd.org Cc: jbeich@freebsd.org, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, henry.hu.sh@gmail.com Subject: Re: svn commit: r484686 - head/net-im/telegram-desktop Message-ID: <CAJie3yok0wHkskBujhRv9LcTTu-WjuHZhsBXMXN%2BapmZsDaZTQ@mail.gmail.com> In-Reply-To: <20181112183423.xmp67tjjghceot75@atuin.in.mat.cc> References: <201811111145.wABBjKcf027649@repo.freebsd.org> <5zx3-zver-wny@FreeBSD.org> <4618826.YNO7O01DYZ@mercury.ph.man.ac.uk> <20181112183423.xmp67tjjghceot75@atuin.in.mat.cc>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 12 Nov 2018 at 18:34, Mathieu Arnold <mat@freebsd.org> wrote:
>
> On Sun, Nov 11, 2018 at 11:59:48AM +0000, Max Brazhnikov wrote:
> > On =D0=B2=D0=BE=D1=81=D0=BA=D1=80=D0=B5=D1=81=D0=B5=D0=BD=D1=8C=D0=B5, =
11 =D0=BD=D0=BE=D1=8F=D0=B1=D1=80=D1=8F 2018 =D0=B3. 11:49:16 UTC Jan Beich=
wrote:
> > > Max Brazhnikov <makc@FreeBSD.org> writes:
> > > > @@ -82,6 +82,7 @@ post-patch:
> > > > ${FILESDIR}/gyp-patches | \
> > > > ${PATCH} -z .bak -s)
> > > >
> > > > @${ECHO} "#define FREEBSD_QT_PLUGINDIR \"${QT_PLUGINDIR}\"" >
> > > > ${WRKSRC}/Telegram/SourceFiles/FREEBSD_QT_PLUGINDIR.h>
> > > > + ${SED} -i -e "/Icon=3D/s|telegram|${PORTNAME}|"
> > > > ${WRKSRC}/lib/xdg/telegramdesktop.desktop
> > > Why ${SED} -i instead of ${REINPLACE_CMD}?
> >
> > For sake of consistency with the rest of the file. I leave it to mainta=
iner.
>
> The reason we have committers and not a simple script that commits every
> patch that applies in is so that people who know better (the committers,
> you, Jan, me) fix submissions from maintainers to match our policies and
> way of doing things.
>
> Now, the Makefile is consistenly bad, that is for sure.
Sorry, folks. I promise to take next PR for this port and make it decent :)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJie3yok0wHkskBujhRv9LcTTu-WjuHZhsBXMXN%2BapmZsDaZTQ>