Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 23 Sep 2024 17:13:04 GMT
From:      Doug Moore <dougm@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: 940fec94b5fc - main - swap_pager: deoptimize swapoff_object
Message-ID:  <202409231713.48NHD45j033689@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by dougm:

URL: https://cgit.FreeBSD.org/src/commit/?id=940fec94b5fc001333d87c2935de97a4566a0289

commit 940fec94b5fc001333d87c2935de97a4566a0289
Author:     Doug Moore <dougm@FreeBSD.org>
AuthorDate: 2024-09-23 17:11:55 +0000
Commit:     Doug Moore <dougm@FreeBSD.org>
CommitDate: 2024-09-23 17:11:55 +0000

    swap_pager: deoptimize swapoff_object
    
    Undo a change in swap_pager_swapoff_object that assumed a swap block
    would be valid after reacquiring a lock, when that validity cannot be
    assumed.
    
    Reviewed by:    markj
    Differential Revision:  https://reviews.freebsd.org/D46753
---
 sys/vm/swap_pager.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/sys/vm/swap_pager.c b/sys/vm/swap_pager.c
index 44fe4f34bb39..954228dfaaf0 100644
--- a/sys/vm/swap_pager.c
+++ b/sys/vm/swap_pager.c
@@ -1954,7 +1954,6 @@ swap_pager_swapoff_object(struct swdevt *sp, vm_object_t object)
 		vm_object_pip_wakeupn(object, 1);
 		KASSERT(vm_page_all_valid(m),
 		    ("%s: Page %p not all valid", __func__, m));
-		swp_pager_force_dirty(&range, m, &sb->d[i]);
 		vm_page_xunbusy(m);
 		i = 0;	/* Restart scan after object lock dropped. */
 	}



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202409231713.48NHD45j033689>