Date: Thu, 12 Feb 2004 08:37:05 -0800 From: Tim Kientzle <kientzle@acm.org> To: juli mallett <jmallett@FreeBSD.ORG> Cc: cvs-src@FreeBSD.ORG Subject: Re: cvs commit: src/lib/libarchive Makefile Message-ID: <402BABB1.7060501@acm.org> In-Reply-To: <20040212075852.GA93983@FreeBSD.org> References: <200402120411.i1C4Bf8U036349@repoman.freebsd.org> <xzpznbodbo6.fsf@dwp.des.no> <20040212075852.GA93983@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
* Dag-Erling Smørgrav <des@des.no> [ Date: 2004-02-12 ]
[ w.r.t. Re: cvs commit: src/lib/libarchive Makefile ]
>Tim Kientzle <kientzle@FreeBSD.org> writes:
>
>> Log:
>> libarchive itself is now completely clean at WARNS=10 on all architectures.
>>
>> Unfortunately, the stock zlib.h is not:
>> line 885: 'err' parameter shadows global 'err' definition from <err.h>
>
>This is trivial to fix, if we're willing to take zlib.h off the vendor
>branch or manage to convince Gailly to take our patch.
Taking zlib.h off the vendor branch is a decision
I'll leave to Peter, who has been maintaining our
zlib import and will probably suffer the consequences
at the next import.
Convincing Gailly to take our patch is a good idea, but
one that will take a while to implement. (Especially
since we're several versions behind his current zlib work.)
juli mallett wrote:
> Personally, I'm against prototype declarations in headers being
> warning checked for parameter names, even moreso for headers not
> included within the headers in question.
My personal preference has always been to comment the names
in prototype declarations, e.g.:
int foo(int /* err */);
That way:
a) The name is there to document the parameter
b) You avoid problems with over-zealous compiler
warnings, macro expansions, etc.
"Fixing" the compiler is certainly an approach, but there
are a lot of compilers out there and we can't fix them all. ;-)
Tim
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?402BABB1.7060501>