Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 24 Oct 2013 22:21:32 +0000 (UTC)
From:      Peter Grehan <grehan@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r257078 - head/sys/net
Message-ID:  <201310242221.r9OMLW2t063564@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: grehan
Date: Thu Oct 24 22:21:31 2013
New Revision: 257078
URL: http://svnweb.freebsd.org/changeset/base/257078

Log:
  Fix panic in the tap driver when a tap and vmnet interface were
  created after each other e.g.
  
   ifconfig tap0
   ifconfig vmnet0
   <panic>
  
  Appears to be a cut'n'paste error from the tap code to the vmnet
  code where the name string wasn't updated in the call to make_dev().
  
  Reviewed by:	glebius
  MFC after:	3 days

Modified:
  head/sys/net/if_tap.c

Modified: head/sys/net/if_tap.c
==============================================================================
--- head/sys/net/if_tap.c	Thu Oct 24 21:58:14 2013	(r257077)
+++ head/sys/net/if_tap.c	Thu Oct 24 22:21:31 2013	(r257078)
@@ -205,7 +205,7 @@ vmnet_clone_create(struct if_clone *ifc,
 	i = clone_create(&tapclones, &tap_cdevsw, &unit, &dev, VMNET_DEV_MASK);
 	if (i) {
 		dev = make_dev(&tap_cdevsw, unit | VMNET_DEV_MASK, UID_ROOT,
-		    GID_WHEEL, 0600, "%s%d", tapname, unit);
+		    GID_WHEEL, 0600, "%s%d", vmnetname, unit);
 	}
 
 	tapcreate(dev);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201310242221.r9OMLW2t063564>