Date: Sat, 17 Dec 2011 22:54:33 +0100 From: Dimitry Andric <dim@FreeBSD.org> To: mdf@FreeBSD.org Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r228625 - head/usr.bin/csup Message-ID: <4EED0F99.2020306@FreeBSD.org> In-Reply-To: <CAMBSHm9cBbCxZ9MvgPvKgYfSxPSpeofgTq0NnJo=e3tR5idxEQ@mail.gmail.com> References: <201112171314.pBHDEjtQ060509@svn.freebsd.org> <CAMBSHm9cBbCxZ9MvgPvKgYfSxPSpeofgTq0NnJo=e3tR5idxEQ@mail.gmail.com>
index | next in thread | previous in thread | raw e-mail
On 2011-12-17 22:32, mdf@FreeBSD.org wrote: ... >> In usr.bin/csup/auth.c, use the correct number of bytes for zeroing the >> shared secret, and use long long format to snprintf a time_t. > If casting is necessary, style prefers intmax_t or uintmax_t, since > those are always wide enough. I don't see anything about that in style(9), maybe it should be added then? In any case, I only changed the %ld format to %lld, because time_t is int, long or long long depending on arch. Long long is just the widest type required in this case.help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4EED0F99.2020306>