Date: Thu, 21 Sep 2023 13:53:33 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 270035] Developer checks for stage-qa emit false positives re: USES= ssl with OpenSSL ports Message-ID: <bug-270035-7788-IpMs46u7aN@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-270035-7788@https.bugs.freebsd.org/bugzilla/> References: <bug-270035-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D270035 --- Comment #3 from Fernando Apestegu=C3=ADa <fernape@FreeBSD.org> --- Created attachment 245093 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D245093&action= =3Dedit Patch for qa.sh qa.sh checks the library requirements for every elf executable and .so file= in the staging directory. If readelf(1) reports a NEEDED libcrypto.so or NEEDED libssl.so for the executable or .so file, then it warns about USES=3Dssl if= not found in the port's Makefile. In the case of security/libressl, qa.sh detects these libraries needed: Warning: (0x0000000000000001 NEEDED Shared library: [libcrypto.so.50]) in /usr/local/bin/ocspcheck Warning: (0x0000000000000001 NEEDED Shared library: [libssl.so.53]) in /usr/local/bin/openssl Warning: (0x0000000000000001 NEEDED Shared library: [libcrypto.so.50]) in /usr/local/bin/openssl Warning: (0x0000000000000001 NEEDED Shared library: [libcrypto.so.50]) in /usr/local/lib/libssl.so.53.0.2 I think if the port itself provides the libcrypto.so or libssl.so libraries, then we shouldn't check for the USES=3Dssl. This patch tries to address this case. It seems to work. It still warns for other ports if they link against those libraries, the libraries are not provided by the port itself and USES=3Dssl is not used. Would you give it a try? --=20 You are receiving this mail because: You are on the CC list for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-270035-7788-IpMs46u7aN>