Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 26 Jun 2012 11:35:34 -0700 (PDT)
From:      Pedro Giffuni <pfg@freebsd.org>
To:        Mark Peek <mp@FreeBSD.org>
Cc:        gnn@FreeBSD.org, freebsd-current@FreeBSD.org
Subject:   Re: [RFT] llquantize for FreeBSD's dtrace
Message-ID:  <1340735734.53528.YahooMailClassic@web113510.mail.gq1.yahoo.com>
In-Reply-To: <4FE9EFF9.9080507@FreeBSD.org>

index | next in thread | previous in thread | raw e-mail



--- Mar 26/6/12, Mark Peek <mp@FreeBSD.org> ha scritto:

> >
> > It's a different assertion.
> >
> > Probably some difference between Solaris and BSD.
> > this is very useful, thanks!
> 
> Try this, change the assert on line 1429 in file dt_cc.c
> from:
> 
> assert(!(arg & (UINT16_MAX << args[i].shift)));
> 
> to
> 
> assert(!(arg & ((uint64_t)UINT16_MAX <<
> args[i].shift)));
> 

This certainly looks correct. Thanks Mark !

I updated the patch:

http://people.freebsd.org/~pfg/patches/patch-dtrace-llquantize

cheers,

Pedro.


help

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1340735734.53528.YahooMailClassic>