Date: Sun, 2 Feb 1997 13:50:48 -0800 From: obrien@NUXI.com (David O'Brien) To: freebsd-ports@freebsd.org (FreeBSD ports list) Cc: hackers@freebsd.org Subject: conditionally including <sys/param.h> Message-ID: <19970202135048.PN07710@dragon.nuxi.com> In-Reply-To: <Pine.OSF.3.95q.970127210526.2115E-100000@uplink.eng.umd.edu>; from Chuck Robey on Jan 27, 1997 21:08:40 -0500 References: <199701280143.RAA06503@freefall.freebsd.org> <Pine.OSF.3.95q.970127210526.2115E-100000@uplink.eng.umd.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
Sorry to have to bring this back to light... I was under the impression that we had agreed that "#if (defined(__unix__) || defined(unix))" was the best way to conditionally include <sys/param.h>. However, this email from Chuck, implies that this is a Bad Thing. So to re-hash this, what does the list think is the best way to have an easy way to include <sys/param.h>? Even thought I don't have all the *BSD folks in my grips like I did at USENIX, I'm still not above trying to get a new cpp symbol added (like __44bsd__ or something). Chuck Robey writes: > > obrien 97/01/27 17:43:23 > > Modified: share/doc/handbook porting.sgml > > Document the "#if (defined(__unix__) || defined(unix))" way of including > > sys/param.h. Change _HAVE_PARAM_H to "HAVE_SYS_PARAM_H" for those who > > still like this method -- leading underscores are in the compiler/library > > name space and the Ollivier says to follow GNU Autoconf anyway. > > That test is completely bogus, cause it passes for all sysv systems, > which _don't_ have sys/param.h. It's a completely useless test, and > someone justified it by saying that "most systems have a sys/param.h > anyhow". > > What (in my own opinion) should have been done is to detect: > > #ifdef FreeBSD || NetBSD || OpenBSD > > that would have worked for those variants. Would be able to find out the > one for BSDi systems, then we'd have a great deal of the important ones. > That's how X11R6 does it. -- -- David (obrien@NUXI.com -or- obrien@FreeBSD.org)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?19970202135048.PN07710>