Date: Wed, 31 Jan 2024 20:53:49 -0500 From: Ed Maste <emaste@freebsd.org> To: Warner Losh <imp@bsdimp.com> Cc: src-committers <src-committers@freebsd.org>, "<dev-commits-src-all@freebsd.org>" <dev-commits-src-all@freebsd.org>, "<dev-commits-src-main@freebsd.org>" <dev-commits-src-main@freebsd.org> Subject: Re: git: ed3563b0ac31 - main - csu: add crtbrand.o dependency on sys/param.h Message-ID: <CAPyFy2CmV2vMQH8D0-VbhvG5oNCha=3p3Qte3Kq3tTFoWkD22w@mail.gmail.com> In-Reply-To: <CANCZdfqCWMd_tzRwHR4=kQHmuVZPyvdvEW6ZRWUVqbN4VC%2BY2Q@mail.gmail.com> References: <202401312041.40VKfgE0080600@gitrepo.freebsd.org> <CANCZdfqCWMd_tzRwHR4=kQHmuVZPyvdvEW6ZRWUVqbN4VC%2BY2Q@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 31 Jan 2024 at 15:57, Warner Losh <imp@bsdimp.com> wrote: > >> commit ed3563b0ac31d854bf907d4d847ac0195ec9637b >> Author: Ed Maste <emaste@FreeBSD.org> >> AuthorDate: 2024-01-12 15:01:49 +0000 >> Commit: Ed Maste <emaste@FreeBSD.org> >> CommitDate: 2024-01-31 20:40:27 +0000 >> >> csu: add crtbrand.o dependency on sys/param.h >> >> __FreeBSD_version is recorded in *crt1.o and crti.o via crtbrand.o. Add >> an explicit dependency to pick up __FreeBSD_version bumps. >> >> Additional changes are required to fully plumb *crt1.o dependencies >> through the build. > > So a kernel bump now rebuilds (or at least relinks) everything? Or soon will? Right now no, because of the second point in the commit message - we don't currently record the dependency on *crt*.o files. We should do that though; clean and NO_CLEAN builds should produce identical output. Once that dependency is added, bumping __FreeBSD_version will indeed cause everything to be rebuilt. If that's too annoying we could add a src.conf knob to skip those dependencies to provide fast but inconsistent builds as today.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPyFy2CmV2vMQH8D0-VbhvG5oNCha=3p3Qte3Kq3tTFoWkD22w>