Date: Mon, 14 Apr 2003 12:28:19 +0200 From: "Poul-Henning Kamp" <phk@phk.freebsd.dk> To: Gavin Atkinson <gavin@ury.york.ac.uk> Cc: freebsd-current@freebsd.org Subject: Re: kernel: bad malloc : 4 Message-ID: <7646.1050316099@critter.freebsd.dk> In-Reply-To: Your message of "Mon, 14 Apr 2003 11:18:14 BST." <20030414105157.G47006-100000@endor.bu.nker.net>
next in thread | previous in thread | raw e-mail | index | archive | help
You are right, they are bad and should be fixed. Poul-Henning In message <20030414105157.G47006-100000@endor.bu.nker.net>, Gavin Atkinson wri tes: >On Sun, 13 Apr 2003, Poul-Henning Kamp wrote: >> In message <20030413140647.GA18474@gilberto.physik.rwth-aachen.de>, "Christoph >> P. Kukulies" writes: >> >Here is what I could type off the screen: >> > >> >Bad malloc flags: 4 >> >> This means that malloc() was called with M_DONTWAIT which is a mbuf >> allocator flags. > >It looks like this is done in a few places in other bits of code... > >sys/netinet/ip_fw.c: ipfw_dyn_v = malloc(curr_dyn_buckets * sizeof r, >sys/netinet/ip_fw.c- M_IPFW, M_DONTWAIT | M_ZERO); >sys/netinet/ip_fw.c- if (ipfw_dyn_v == NULL) > >sys/netinet6/frag6.c: q6 = (struct ip6q *)malloc(sizeof(struct ip6q), M_FTABLE, >sys/netinet6/frag6.c- M_DONTWAIT); >sys/netinet6/frag6.c- if (q6 == NULL) > >sys/netinet6/frag6.c: ip6af = (struct ip6asfrag *)malloc(sizeof(struct ip6asfrag), M_FTABLE, >sys/netinet6/frag6.c- M_DONTWAIT); >sys/netinet6/frag6.c- if (ip6af == NULL) > >So, these are bad? It looks like they were fixed in January by imp, and >then backed out in February. I have no idea why it was backed out. > >Gavin > > -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7646.1050316099>