Date: Sun, 8 Feb 2004 03:45:19 -0500 (EST) From: Andre Guibert de Bruet <andy@siliconlandmark.com> To: current@freebsd.org Subject: make_dev(9) perms for SCSI & SCSI RAID drivers in CURRENT. Message-ID: <20040208022417.M91658@alpha.siliconlandmark.com>
next in thread | raw e-mail | index | archive | help
This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. Send mail to mime@docserver.cac.washington.edu for more info. --0-452794435-1076228556=:91658 Content-Type: TEXT/PLAIN; CHARSET=US-ASCII Content-ID: <20040208034019.W91658@alpha.siliconlandmark.com> Hi, While studying the various FreeBSD SCSI and SCSI RAID drivers, I noticed that the file mode (perm mask) varies per driver. So far, I've come across 0600, 0640 and 0644. I can't really see why any of these drivers would have anything other than 0600, as it would require root access or at least write perm to do anything useful with the card. Here's a quick illustration of what I'm refering to: aac 0640 (octal notation in code) amr 0600 (implemented as S_IRUSR | S_IWUSR) asr 0640 (octal notation in code) ciss 0600 (implemented as S_IRUSR | S_IWUSR) ida 0600 (implemented as S_IRUSR | S_IWUSR) iir 0644 (implemented as S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH) ips 0600 (implemented as S_IRUSR | S_IWUSR) isp 0600 (octal notation in code) mly 0600 (implemented as S_IRUSR | S_IWUSR) I've attached a set of patches that make the aac, asr, iir and isp drivers conform to S_IRUSR | S_IWUSR. I don't have all of these cards, but the drivers build on today's CURRENT and these changes are rather minor. As always, comments are welcome. :) Regards, Andy > Andre Guibert de Bruet | Enterprise Software Consultant > > Silicon Landmark, LLC. | http://siliconlandmark.com/ > --0-452794435-1076228556=:91658 Content-Type: TEXT/PLAIN; CHARSET=US-ASCII; NAME="aac.c.perm.patch" Content-Transfer-Encoding: BASE64 Content-ID: <20040208032236.S91658@alpha.siliconlandmark.com> Content-Description: Content-Disposition: ATTACHMENT; FILENAME="aac.c.perm.patch" SW5kZXg6IGFhYy5jDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQpSQ1MgZmls ZTogL2hvbWUvbmN2cy9zcmMvc3lzL2Rldi9hYWMvYWFjLmMsdg0KcmV0cmll dmluZyByZXZpc2lvbiAxLjg1DQpkaWZmIC11IC1yMS44NSBhYWMuYw0KLS0t IGFhYy5jCTcgRmViIDIwMDQgMTc6NDA6MzcgLTAwMDAJMS44NQ0KKysrIGFh Yy5jCTggRmViIDIwMDQgMDg6MDk6NDggLTAwMDANCkBAIC01MSw2ICs1MSw3 IEBADQogI2luY2x1ZGUgPHN5cy9zaWduYWx2YXIuaD4NCiAjaW5jbHVkZSA8 c3lzL3RpbWUuaD4NCiAjaW5jbHVkZSA8c3lzL2V2ZW50aGFuZGxlci5oPg0K KyNpbmNsdWRlIDxzeXMvc3RhdC5oPg0KIA0KICNpbmNsdWRlIDxtYWNoaW5l L2J1c19tZW1pby5oPg0KICNpbmNsdWRlIDxtYWNoaW5lL2J1cy5oPg0KQEAg LTI3MSw3ICsyNzIsNyBAQA0KIAkgKi8NCiAJdW5pdCA9IGRldmljZV9nZXRf dW5pdChzYy0+YWFjX2Rldik7DQogCXNjLT5hYWNfZGV2X3QgPSBtYWtlX2Rl digmYWFjX2NkZXZzdywgdW5pdCwgVUlEX1JPT1QsIEdJRF9PUEVSQVRPUiwN Ci0JCQkJIDA2NDAsICJhYWMlZCIsIHVuaXQpOw0KKwkJCQkgU19JUlVTUiB8 IFNfSVdVU1IsICJhYWMlZCIsIHVuaXQpOw0KIAkodm9pZCltYWtlX2Rldl9h bGlhcyhzYy0+YWFjX2Rldl90LCAiYWZhJWQiLCB1bml0KTsNCiAJKHZvaWQp bWFrZV9kZXZfYWxpYXMoc2MtPmFhY19kZXZfdCwgImhwbiVkIiwgdW5pdCk7 DQogCXNjLT5hYWNfZGV2X3QtPnNpX2RydjEgPSBzYzsNCg== --0-452794435-1076228556=:91658 Content-Type: TEXT/PLAIN; CHARSET=US-ASCII; NAME="asr.c.perm.patch" Content-Transfer-Encoding: BASE64 Content-ID: <20040208032236.Y91658@alpha.siliconlandmark.com> Content-Description: Content-Disposition: ATTACHMENT; FILENAME="asr.c.perm.patch" SW5kZXg6IGFzci5jDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQpSQ1MgZmls ZTogL2hvbWUvbmN2cy9zcmMvc3lzL2Rldi9hc3IvYXNyLmMsdg0KcmV0cmll dmluZyByZXZpc2lvbiAxLjM4DQpkaWZmIC11IC1yMS4zOCBhc3IuYw0KLS0t IGFzci5jCTI2IFNlcCAyMDAzIDE1OjU2OjQyIC0wMDAwCTEuMzgNCisrKyBh c3IuYwk4IEZlYiAyMDA0IDA3OjU5OjE4IC0wMDAwDQpAQCAtMzEyNyw4ICsz MTI3LDggQEANCiAJLyoNCiAJICoJR2VuZXJhdGUgdGhlIGRldmljZSBub2Rl IGluZm9ybWF0aW9uDQogCSAqLw0KLQkodm9pZCltYWtlX2RldigmYXNyX2Nk ZXZzdywgdW5pdCwgVUlEX1JPT1QsIEdJRF9PUEVSQVRPUiwgMDY0MCwNCi0J ICAgICJyYXNyJWQiLCB1bml0KTsNCisJKHZvaWQpbWFrZV9kZXYoJmFzcl9j ZGV2c3csIHVuaXQsIFVJRF9ST09ULCBHSURfT1BFUkFUT1IsDQorCSAgICBT X0lSVVNSIHwgU19JV1VTUiwgInJhc3IlZCIsIHVuaXQpOw0KIAlBVFRBQ0hf UkVUVVJOKDApOw0KIH0gLyogYXNyX2F0dGFjaCAqLw0KIA0K --0-452794435-1076228556=:91658 Content-Type: TEXT/PLAIN; CHARSET=US-ASCII; NAME="iir_ctrl.c.perm.patch" Content-Transfer-Encoding: BASE64 Content-ID: <20040208032236.O91658@alpha.siliconlandmark.com> Content-Description: Content-Disposition: ATTACHMENT; FILENAME="iir_ctrl.c.perm.patch" SW5kZXg6IGlpcl9jdHJsLmMNCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NClJD UyBmaWxlOiAvaG9tZS9uY3ZzL3NyYy9zeXMvZGV2L2lpci9paXJfY3RybC5j LHYNCnJldHJpZXZpbmcgcmV2aXNpb24gMS4xMQ0KZGlmZiAtdSAtcjEuMTEg aWlyX2N0cmwuYw0KLS0tIGlpcl9jdHJsLmMJMjYgU2VwIDIwMDMgMTU6MzY6 NDcgLTAwMDAJMS4xMQ0KKysrIGlpcl9jdHJsLmMJOCBGZWIgMjAwNCAwNzo1 Njo0NSAtMDAwMA0KQEAgLTEwMywxMiArMTAzLDEyIEBADQogDQogI2lmZGVm IFNERVZfUEVSX0hCQQ0KICAgICBkZXYgPSBtYWtlX2RldigmaWlyX2NkZXZz dywgaGJhMm1pbm9yKHVuaXQpLCBVSURfUk9PVCwgR0lEX09QRVJBVE9SLA0K LSAgICAgICAgICAgICAgICAgICBTX0lSVVNSIHwgU19JV1VTUiB8IFNfSVJH UlAgfCBTX0lST1RILCAiaWlyJWQiLCB1bml0KTsNCisgICAgICAgICAgICAg ICAgICAgU19JUlVTUiB8IFNfSVdVU1IsICJpaXIlZCIsIHVuaXQpOw0KICNl bHNlDQogICAgIGlmIChzZGV2X21hZGUpDQogICAgICAgICByZXR1cm4gKDAp Ow0KICAgICBkZXYgPSBtYWtlX2RldigmaWlyX2NkZXZzdywgMCwgVUlEX1JP T1QsIEdJRF9PUEVSQVRPUiwNCi0gICAgICAgICAgICAgICAgICAgU19JUlVT UiB8IFNfSVdVU1IgfCBTX0lSR1JQIHwgU19JUk9USCwgImlpciIpOw0KKyAg ICAgICAgICAgICAgICAgICBTX0lSVVNSIHwgU19JV1VTUiwgImlpciIpOw0K ICAgICBzZGV2X21hZGUgPSAxOw0KICNlbmRpZg0KICAgICByZXR1cm4gKGRl dik7DQo= --0-452794435-1076228556=:91658 Content-Type: TEXT/PLAIN; CHARSET=US-ASCII; NAME="isp_freebsd.c.perm.patch" Content-Transfer-Encoding: BASE64 Content-ID: <20040208032236.G91658@alpha.siliconlandmark.com> Content-Description: Content-Disposition: ATTACHMENT; FILENAME="isp_freebsd.c.perm.patch" SW5kZXg6IGlzcF9mcmVlYnNkLmMNCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0N ClJDUyBmaWxlOiAvaG9tZS9uY3ZzL3NyYy9zeXMvZGV2L2lzcC9pc3BfZnJl ZWJzZC5jLHYNCnJldHJpZXZpbmcgcmV2aXNpb24gMS45Ng0KZGlmZiAtdSAt cjEuOTYgaXNwX2ZyZWVic2QuYw0KLS0tIGlzcF9mcmVlYnNkLmMJNyBGZWIg MjAwNCAwMzo0NzozMyAtMDAwMAkxLjk2DQorKysgaXNwX2ZyZWVic2QuYwk4 IEZlYiAyMDA0IDA4OjEyOjQwIC0wMDAwDQpAQCAtMzUsNiArMzUsNyBAQA0K ICNpbmNsdWRlIDxzeXMvY29uZi5oPg0KICNpbmNsdWRlIDxzeXMvbW9kdWxl Lmg+DQogI2luY2x1ZGUgPHN5cy9pb2Njb20uaD4NCisjaW5jbHVkZSA8c3lz L3N0YXQuaD4NCiAjaW5jbHVkZSA8ZGV2L2lzcC9pc3BfaW9jdGwuaD4NCiAN CiANCkBAIC0yMTEsNyArMjEyLDcgQEANCiAJICogQ3JlYXRlIGRldmljZSBu b2Rlcw0KIAkgKi8NCiAJKHZvaWQpIG1ha2VfZGV2KCZpc3BfY2RldnN3LCBk ZXZpY2VfZ2V0X3VuaXQoaXNwLT5pc3BfZGV2KSwgVUlEX1JPT1QsDQotCSAg ICBHSURfT1BFUkFUT1IsIDA2MDAsICIlcyIsIGRldmljZV9nZXRfbmFtZXVu aXQoaXNwLT5pc3BfZGV2KSk7DQorCSAgICBHSURfT1BFUkFUT1IsIFNfSVJV U1IgfCBTX0lXVVNSLCAiJXMiLCBkZXZpY2VfZ2V0X25hbWV1bml0KGlzcC0+ aXNwX2RldikpOw0KIA0KIAlpZiAoaXNwLT5pc3Bfcm9sZSAhPSBJU1BfUk9M RV9OT05FKSB7DQogCQlpc3AtPmlzcF9zdGF0ZSA9IElTUF9SVU5TVEFURTsN Cg== --0-452794435-1076228556=:91658--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040208022417.M91658>