Date: Thu, 4 Jul 2019 10:56:31 -0400 From: Mark Johnston <markj@freebsd.org> To: Roger Pau =?iso-8859-1?Q?Monn=E9?= <roger.pau@citrix.com> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r349423 - head/contrib/elftoolchain/elfcopy Message-ID: <20190704145631.GA63719@raichu> In-Reply-To: <20190704135649.dsjxkuvj6j25ywdw@Air-de-Roger> References: <201906261635.x5QGZbJ7051084@repo.freebsd.org> <20190704135649.dsjxkuvj6j25ywdw@Air-de-Roger>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Jul 04, 2019 at 03:56:49PM +0200, Roger Pau Monné wrote: > On Wed, Jun 26, 2019 at 04:35:37PM +0000, Mark Johnston wrote: > > Author: markj > > Date: Wed Jun 26 16:35:37 2019 > > New Revision: 349423 > > URL: https://svnweb.freebsd.org/changeset/base/349423 > > > > Log: > > elfcopy: Provide a size hint when creating the section string table. > > > > Use the input file's .shstrtab size as the hint if it exists. This > > gives a small performance improvement when processing files with > > many sections. > > This change breaks the Xen build using objcopy. I have a very simple > test case, pick the file from: > > https://people.freebsd.org/~royger/buildid.ihex > > Then do: > > $ objcopy -I ihex -O binary buildid.ihex buildid.o > objcopy: elf_nextscn failed: Invalid argument > > This used to work before this change, and now fails. Thanks, I posted a patch here: https://reviews.freebsd.org/D20852
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190704145631.GA63719>