Date: Fri, 13 Feb 2004 04:02:46 +1100 (EST) From: Bruce Evans <bde@zeta.org.au> To: Poul-Henning Kamp <phk@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/alpha/alpha support.s src/sys/i386/i386 swtch.s src/sys/kern kern_shutdown.c src/sys/sys systm.h Message-ID: <20040213035557.M24031@gamplex.bde.org> In-Reply-To: <20040120175334.W3279@gamplex.bde.org> References: <200401192127.i0JLRBL3041817@repoman.freebsd.org> <20040120175334.W3279@gamplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 20 Jan 2004, Bruce Evans wrote: > On Mon, 19 Jan 2004, Poul-Henning Kamp wrote: > > > phk 2004/01/19 13:27:11 PST > > > > FreeBSD src repository > > > > Modified files: > > sys/alpha/alpha support.s > > sys/i386/i386 swtch.s > > sys/kern kern_shutdown.c > > sys/sys systm.h > > Log: > > Add linenumber and source filename to panic(9) output. > > This was rejected in all reviews. It gives less information than > grepping the sources, at some cost (grep at least gives correct line > numbers when the sources don't quite match the binary). > > Please back this out. I'm still waiting for this to be backed out. I just found yet another bug in it: it defeats simple regression checks. Suppose you make some cosmetic changes that add a line before a panic. This now changes the object file even when the file is compiled without -g. Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040213035557.M24031>