Date: Sat, 23 Mar 2024 02:50:52 GMT From: Gleb Smirnoff <glebius@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: git: fbbb50f57093 - main - tests/netgraph: mark all tests as required_user="root" Message-ID: <202403230250.42N2oqDJ051898@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch main has been updated by glebius: URL: https://cgit.FreeBSD.org/src/commit/?id=fbbb50f57093307d972a22ef001670dc92dc8f22 commit fbbb50f57093307d972a22ef001670dc92dc8f22 Author: Gleb Smirnoff <glebius@FreeBSD.org> AuthorDate: 2024-03-23 02:50:33 +0000 Commit: Gleb Smirnoff <glebius@FreeBSD.org> CommitDate: 2024-03-23 02:50:33 +0000 tests/netgraph: mark all tests as required_user="root" Any netgraph operation requires root priveleges. Some tests in the directory already mark themselves with 'atf_tc_set_md_var(conf, "require.user", "root");' which creates a lot of pasted code. Some tests don't mark self. For this particular directory a blanket metadata setting in the Makefile is acceptable, imho. --- tests/sys/netgraph/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/sys/netgraph/Makefile b/tests/sys/netgraph/Makefile index 8bf91c68ad6b..36f9943a7312 100644 --- a/tests/sys/netgraph/Makefile +++ b/tests/sys/netgraph/Makefile @@ -8,7 +8,7 @@ TAP_TESTS_SH+= ng_macfilter_test # Serialize tests since some share netgraph node names. TEST_METADATA+= is_exclusive=true -TEST_METADATA.ng_macfilter_test+= required_user="root" +TEST_METADATA+= required_user="root" TEST_METADATA.ng_macfilter_test+= required_programs="perl" ATF_TESTS_C+= basic \
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202403230250.42N2oqDJ051898>