Skip site navigation (1)Skip section navigation (2) 
Date:      Sun, 26 Oct 2008 19:33:22 +0000 (UTC)
From:      Robert Watson <rwatson@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r184298 - head/sys/netinet
Message-ID:  <200810261933.m9QJXMUW093047@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help 
Author: rwatson
Date: Sun Oct 26 19:33:22 2008
New Revision: 184298
URL: http://svn.freebsd.org/changeset/base/184298

Log:
  Remove endearing but syntactically unnecessary "return;" statements
  directly before the final closeing brackets of some TCP functions.
  
  MFC after:	3 days

Modified:
  head/sys/netinet/tcp_input.c
  head/sys/netinet/tcp_sack.c
  head/sys/netinet/tcp_syncache.c

Modified: head/sys/netinet/tcp_input.c
==============================================================================
--- head/sys/netinet/tcp_input.c	Sun Oct 26 19:28:04 2008	(r184297)
+++ head/sys/netinet/tcp_input.c	Sun Oct 26 19:33:22 2008	(r184298)
@@ -925,7 +925,6 @@ drop:
 		free(s, M_TCPLOG);
 	if (m != NULL)
 		m_freem(m);
-	return;
 }
 
 static void
@@ -2529,7 +2528,6 @@ drop:
 	if (headlocked)
 		INP_INFO_WUNLOCK(&V_tcbinfo);
 	m_freem(m);
-	return;
 }
 
 /*
@@ -2588,7 +2586,6 @@ tcp_dropwithreset(struct mbuf *m, struct
 	return;
 drop:
 	m_freem(m);
-	return;
 }
 
 /*

Modified: head/sys/netinet/tcp_sack.c
==============================================================================
--- head/sys/netinet/tcp_sack.c	Sun Oct 26 19:28:04 2008	(r184297)
+++ head/sys/netinet/tcp_sack.c	Sun Oct 26 19:33:22 2008	(r184298)
@@ -680,5 +680,4 @@ tcp_sack_adjust(struct tcpcb *tp)
 	if (SEQ_LT(tp->snd_nxt, cur->end))
 		return;
 	tp->snd_nxt = tp->snd_fack;
-	return;
 }

Modified: head/sys/netinet/tcp_syncache.c
==============================================================================
--- head/sys/netinet/tcp_syncache.c	Sun Oct 26 19:28:04 2008	(r184297)
+++ head/sys/netinet/tcp_syncache.c	Sun Oct 26 19:33:22 2008	(r184298)
@@ -1243,7 +1243,6 @@ done:
 		*lsop = NULL;
 		m_freem(m);
 	}
-	return;
 }
 
 static int
@@ -1576,7 +1575,6 @@ syncookie_generate(struct syncache_head 
 	}
 
 	V_tcpstat.tcps_sc_sendcookie++;
-	return;
 }
 
 static struct syncache *

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200810261933.m9QJXMUW093047>