Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 10 Feb 2006 10:43:50 +0100
From:      Pav Lucistnik <pav@FreeBSD.org>
To:        Jean-Marc Zucconi <jmz@FreeBSD.org>
Cc:        cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject:   Re: cvs commit: ports/benchmarks/iozone Makefile
Message-ID:  <1139564630.84598.18.camel@pav.hide.vol.cz>
In-Reply-To: <200602092158.k19LwDTE044725@repoman.freebsd.org>
References:  <200602092158.k19LwDTE044725@repoman.freebsd.org>

index | next in thread | previous in thread | raw e-mail

[-- Attachment #1 --]
Jean-Marc Zucconi píše v čt 09. 02. 2006 v 21:58 +0000:
> jmz         2006-02-09 21:58:12 UTC
> 
>   FreeBSD ports repository
> 
>   Modified files:
>     benchmarks/iozone    Makefile 
>   Log:
>   Build fix for 4.x: don't use pthreads
>   
>   Revision  Changes    Path
>   1.45      +4 -2      ports/benchmarks/iozone/Makefile

Heh, this delta is completely bogus. You can't use OPTIONS below
bsd.port.pre.mk. You have to check opposite variable against the default
value of OPTIONS. You must never hardcode -lpthread into the Makefile.

Perhaps it would be a good idea to reread Porter's Handbook and pay a
special attention to all the new stuff which was introduced last year?

-- 
Pav Lucistnik <pav@oook.cz>
              <pav@FreeBSD.org>

Knight: We shall say Ny! again to you if you do not appease us.
Arthur: All right. What do you want?
Knight: We want... a shruberry!

[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (FreeBSD)

iD8DBQBD7GBWntdYP8FOsoIRAqrDAJ4kbr+9oHR+OXWGuiAoUkdR0p7ntACgs9bl
vwLcIkq3GLxLOnecb2oGaJQ=
=/+NP
-----END PGP SIGNATURE-----
help

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1139564630.84598.18.camel>