Date: Tue, 4 Jan 2022 14:48:00 GMT From: Mark Johnston <markj@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: git: ed166a017324 - main - mvneta: Unconditionally print an error message if mii_attach() fails Message-ID: <202201041448.204Em04B057204@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=ed166a0173247e267c507ebd0ec03cb04aaf49ee commit ed166a0173247e267c507ebd0ec03cb04aaf49ee Author: Mark Johnston <markj@FreeBSD.org> AuthorDate: 2022-01-04 14:42:34 +0000 Commit: Mark Johnston <markj@FreeBSD.org> CommitDate: 2022-01-04 14:46:23 +0000 mvneta: Unconditionally print an error message if mii_attach() fails The error message is useful for diagnosing mvneta_attach() failures. MFC after: 1 week --- sys/dev/neta/if_mvneta.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/sys/dev/neta/if_mvneta.c b/sys/dev/neta/if_mvneta.c index 4d54e95e807d..0ea86330877b 100644 --- a/sys/dev/neta/if_mvneta.c +++ b/sys/dev/neta/if_mvneta.c @@ -724,10 +724,8 @@ mvneta_attach(device_t self) mvneta_mediastatus, BMSR_DEFCAPMASK, sc->phy_addr, MII_OFFSET_ANY, 0); if (error != 0) { - if (bootverbose) { - device_printf(self, - "MII attach failed, error: %d\n", error); - } + device_printf(self, "MII attach failed, error: %d\n", + error); ether_ifdetach(sc->ifp); mvneta_detach(self); return (error);
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202201041448.204Em04B057204>