Date: Mon, 5 Feb 2024 08:34:16 -0700 From: Warner Losh <imp@bsdimp.com> To: Cy Schubert <Cy.Schubert@cschubert.com> Cc: Andriy Gapon <avg@freebsd.org>, Jung-uk Kim <jkim@freebsd.org>, Baptiste Daroussin <bapt@freebsd.org>, src-committers <src-committers@freebsd.org>, "<dev-commits-src-all@freebsd.org>" <dev-commits-src-all@freebsd.org>, "<dev-commits-src-main@freebsd.org>" <dev-commits-src-main@freebsd.org>, Dmitry Salychev <dsl@mcusim.org> Subject: Re: git: 07c64d74917e - main - acpica: Import ACPICA 20230628 Message-ID: <CANCZdfrs%2BHZnvPz4pXhLxtd_kA_yUoUMRvrvzbQGJumEgrPmQg@mail.gmail.com> In-Reply-To: <CANCZdfqVe%2BMGM846HPnMdHP=hhy6mKK2VHagzZ9R9p4C7JZgXA@mail.gmail.com> References: <737703f2-26a6-4a84-a64b-3fa55cad721c@FreeBSD.org> <20240131204355.9EA2B19F@slippy.cwsent.com> <CANCZdfqVe%2BMGM846HPnMdHP=hhy6mKK2VHagzZ9R9p4C7JZgXA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Wed, Jan 31, 2024 at 1:59 PM Warner Losh <imp@bsdimp.com> wrote: > > > On Wed, Jan 31, 2024, 1:44 PM Cy Schubert <Cy.Schubert@cschubert.com> > wrote: > >> In message <737703f2-26a6-4a84-a64b-3fa55cad721c@FreeBSD.org>, Andriy >> Gapon >> wri >> tes: >> > On 31/01/2024 19:40, Cy Schubert wrote: >> > > In message <04c4a0e1-aa79-4d25-a1f7-2196cfa65578@FreeBSD.org>, >> Jung-uk Kim >> > > writ >> > > es: >> > >> On 24. 1. 31., Baptiste Daroussin wrote: >> > >>> Hello, >> > >>> >> > >>> Either this one or the previous import is breaking arm64 build >> > >>> >> > >>> --- acpi_iort.o --- >> > >>> /home/bapt/worktrees/main/sys/arm64/acpica/acpi_iort.c:103:4: >> error: fiel >> > d >> > >>> 'data' with variable sized type 'union (unnamed union at >> > >>> /home/bapt/worktrees/main/sys/arm64/acpica/acpi_iort.c:98:2 >> > >>> )' not at the end of a struct or class is a GNU extension >> > >>> [-Werror,-Wgnu-variable-sized-type-not-at-end] >> > >>> 103 | } data; >> > >>> | ^ >> > >> >> > >> Sorry for the breakage. I will fix it soon. >> > >> >> > >> BTW, this code was added by this: >> > >> >> > >> https://reviews.freebsd.org/D31267 >> > >> >> > >> It seems struct iort_named_component was a hack, which duplicated >> > >> ACPI_IORT_NAMED_COMPONENT but with a fixed length field >> DeviceName[32]. >> > >> Is it really necessary? >> > > >> > > Though they incorporated the WOL patch I've been using, they've broken >> > > poweroff. >> > >> > The poweroff issue could be because of 9cdf326b4f >> >> Thanks. I clued into that a while ago after taking a break to read the ML. >> >> This smelled of the original WOL problem I had last year that required >> pulling the plug to allow the NIC to see the magic packet, but worse. >> Hence >> I was barking up the wrong tree. >> > > On an semi-related issue... mind if I do a proper merge commit to catch up > and not leave hidden landmines for the future? > OK. I'll do a proper merge commit. We've accumulated a few dozen conflicts I'll have to sort out (though I think they are all in files we don't user or have deleted). Warner > Warner > >> >> -- >> Cheers, >> Cy Schubert <Cy.Schubert@cschubert.com> >> FreeBSD UNIX: <cy@FreeBSD.org> Web: https://FreeBSD.org >> NTP: <cy@nwtime.org> Web: https://nwtime.org >> >> e^(i*pi)+1=0 >> >> >> [-- Attachment #2 --] <div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Jan 31, 2024 at 1:59 PM Warner Losh <<a href="mailto:imp@bsdimp.com">imp@bsdimp.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="auto"><div><br><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Jan 31, 2024, 1:44 PM Cy Schubert <<a href="mailto:Cy.Schubert@cschubert.com" target="_blank">Cy.Schubert@cschubert.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">In message <737703f2-26a6-4a84-a64b-3fa55cad721c@FreeBSD.org>, Andriy Gapon <br> wri<br> tes:<br> > On 31/01/2024 19:40, Cy Schubert wrote:<br> > > In message <04c4a0e1-aa79-4d25-a1f7-2196cfa65578@FreeBSD.org>, Jung-uk Kim<br> > > writ<br> > > es:<br> > >> On 24. 1. 31., Baptiste Daroussin wrote:<br> > >>> Hello,<br> > >>><br> > >>> Either this one or the previous import is breaking arm64 build<br> > >>><br> > >>> --- acpi_iort.o ---<br> > >>> /home/bapt/worktrees/main/sys/arm64/acpica/acpi_iort.c:103:4: error: fiel<br> > d<br> > >>> 'data' with variable sized type 'union (unnamed union at<br> > >>> /home/bapt/worktrees/main/sys/arm64/acpica/acpi_iort.c:98:2<br> > >>> )' not at the end of a struct or class is a GNU extension<br> > >>> [-Werror,-Wgnu-variable-sized-type-not-at-end]<br> > >>> 103 | } data;<br> > >>> | ^<br> > >><br> > >> Sorry for the breakage. I will fix it soon.<br> > >><br> > >> BTW, this code was added by this:<br> > >><br> > >> <a href="https://reviews.freebsd.org/D31267" rel="noreferrer noreferrer" target="_blank">https://reviews.freebsd.org/D31267</a><br>; > >><br> > >> It seems struct iort_named_component was a hack, which duplicated<br> > >> ACPI_IORT_NAMED_COMPONENT but with a fixed length field DeviceName[32].<br> > >> Is it really necessary?<br> > > <br> > > Though they incorporated the WOL patch I've been using, they've broken<br> > > poweroff.<br> ><br> > The poweroff issue could be because of 9cdf326b4f<br> <br> Thanks. I clued into that a while ago after taking a break to read the ML.<br> <br> This smelled of the original WOL problem I had last year that required <br> pulling the plug to allow the NIC to see the magic packet, but worse. Hence <br> I was barking up the wrong tree.<br></blockquote></div></div><div dir="auto"><br></div><div dir="auto">On an semi-related issue... mind if I do a proper merge commit to catch up and not leave hidden landmines for the future?</div></div></blockquote><div><br></div><div>OK. I'll do a proper merge commit. We've accumulated a few dozen conflicts I'll have to sort out (though I think they</div><div>are all in files we don't user or have deleted).</div><div><br></div><div>Warner</div><div> <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="auto"><div dir="auto">Warner</div><div dir="auto"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> <br> -- <br> Cheers,<br> Cy Schubert <<a href="mailto:Cy.Schubert@cschubert.com" rel="noreferrer" target="_blank">Cy.Schubert@cschubert.com</a>><br> FreeBSD UNIX: <cy@FreeBSD.org> Web: <a href="https://FreeBSD.org" rel="noreferrer noreferrer" target="_blank">https://FreeBSD.org</a><br>; NTP: <<a href="mailto:cy@nwtime.org" rel="noreferrer" target="_blank">cy@nwtime.org</a>> Web: <a href="https://nwtime.org" rel="noreferrer noreferrer" target="_blank">https://nwtime.org</a><br>; <br> e^(i*pi)+1=0<br> <br> <br> </blockquote></div></div></div> </blockquote></div></div>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfrs%2BHZnvPz4pXhLxtd_kA_yUoUMRvrvzbQGJumEgrPmQg>