Date: Tue, 28 Oct 2025 22:36:14 GMT From: Warner Losh <imp@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: git: 471743e1315c - main - nvme: Remove a todo comment Message-ID: <202510282236.59SMaE3S008573@gitrepo.freebsd.org>
index | next in thread | raw e-mail
The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=471743e1315cdc54d85e3e77b53e3841b3647ea1 commit 471743e1315cdc54d85e3e77b53e3841b3647ea1 Author: Warner Losh <imp@FreeBSD.org> AuthorDate: 2025-10-28 22:33:36 +0000 Commit: Warner Losh <imp@FreeBSD.org> CommitDate: 2025-10-28 22:35:33 +0000 nvme: Remove a todo comment The storage subsystem really wants one of a very small number of I/O errors. And since we started to do this I/O, EIO is the right error to return. Other errors may get different and weirder treatment up the stack, or even converted to just EIO. So remove this TODO comment that's been there since the initial nvme driver commit. It wouldn't be helpful to do this, and could likely hurt. Sponsored by: Netflix --- sys/dev/nvme/nvme_ns.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/sys/dev/nvme/nvme_ns.c b/sys/dev/nvme/nvme_ns.c index a759181a8c16..f4a588373c98 100644 --- a/sys/dev/nvme/nvme_ns.c +++ b/sys/dev/nvme/nvme_ns.c @@ -142,10 +142,6 @@ nvme_ns_strategy_done(void *arg, const struct nvme_completion *cpl) { struct bio *bp = arg; - /* - * TODO: add more extensive translation of NVMe status codes - * to different bio error codes (i.e. EIO, EINVAL, etc.) - */ if (nvme_completion_is_error(cpl)) { bp->bio_error = EIO; bp->bio_flags |= BIO_ERROR;home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202510282236.59SMaE3S008573>