Date: Thu, 31 May 2012 22:04:09 -0400 From: Tom Judge <tj@freebsd.org> To: Doug Barton <dougb@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Eitan Adler <eadler@FreeBSD.org> Subject: Re: svn commit: r236362 - head/share/misc Message-ID: <4FC82319.4050307@freebsd.org> In-Reply-To: <4FC81AE3.10304@FreeBSD.org> References: <201205311933.q4VJXpnE060290@svn.freebsd.org> <4FC81AE3.10304@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 31/05/2012 21:29, Doug Barton wrote: > On 5/31/2012 12:33 PM, Tom Judge wrote: >> - Sort the node list while I'm here. > > This falls under the category of a "whitespace" change, which > should have been done as a separate commit (usually first, then > substantive changes second). > > This is a tiny bit more work for you, but down the road when > someone who is !tj is reviewing the logs, diffs, etc. it really > helps to make the substantive changes stand out. Feedback noted for next time. Tom -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (Darwin) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBAgAGBQJPyCMZAAoJEEJSM9yB4iIWo1cH/130Fb9qDCpI8jJnukHR4EI1 4LJj7q0TLSNoocvB+JleVpO1i3wOuFJX+jj64yTC/BOuMU9Z/FJ7MxoyBTEOXpBO AfUibDN3jquHKIP1eZLZzGYVSOLUg9sXCTG+yryPKfGvaC5iNhkhH3rL3+QBCLzA pQLEG65rcG2yTgzohEejCyJxSBxNl+8O5WmLRUvn+GQlmefBYh2kHyphLAA2iFE+ J8jC7afDZQMg3TA8OhllEcfg3ErbIpzI/CPoHbr+6A2tKTlbzcb1AKUBFkZPLDib 1uSHkEvLUT+ZTsB+8qDiGbbZ42eMlF206jGf5vXdG5AD9C2Xp2zwVVeya8G5o9Y= =LwiQ -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4FC82319.4050307>