Date: Tue, 22 Aug 2006 01:35:33 +0200 From: "Timur I. Bakeyev" <timur@gnu.org> To: Bill Blue <bblue@controlroom.net>, Rainer Alves <rainer.alves@gmail.com>, ports@freebsd.org, timur@gnu.org Subject: Re: FreeBSD Port: net/samba3 (rc.d weirdness) Message-ID: <20060821233533.GA1487@com.bat.ru> In-Reply-To: <20060816192525.GA1167@roadrunner.buck.local> References: <44DE1656.1020803@rogers.com> <44DE1CFD.4010204@gmail.com> <op.td6pbgxmr2360o@v2.netoldies.com> <20060816192525.GA1167@roadrunner.buck.local>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi, Ulrich!
On Wed, Aug 16, 2006 at 09:25:26PM +0200, Ulrich Spoerlein wrote:
>
> The function "checkyesno" cannot handle undefined variables and will
> thus print an error. This will happen ON EVERY machine that samba3 is
> installed, but there is no samba_enable="YES/NO" line in rc.conf.
>
> The quick fix is to alter the samba script to set a default value (to
> NO), just like almost every other port does, eg., run
>
> $ egrep '_enable:?-"?NO' /usr/local/etc/rc.d/*
>
> 010.pgsql.sh:postgresql_enable=${postgresql_enable:-"NO"}
> privoxy:privoxy_enable=${privoxy_enable-"NO"}
> snmpd:snmpd_enable=${snmpd_enable-"NO"}
> symon:symon_enable=${symon_enable:-"NO"}
>
> I'll CC the maintainer ...
Thanks for pointing me out on this flaw. IIRC, when I first wrote this
script it did work ok. So, seems, something got broken since then.
I'll try to push the changes ASAP, together with some other minor fixes
to the port.
With best regards,
Timur Bakeyev.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060821233533.GA1487>