Date: Mon, 3 Jan 2022 10:51:31 -0800 From: Xin Li via freebsd-current <freebsd-current@freebsd.org> To: freebsd-current <freebsd-current@freebsd.org> Cc: rmacklem@freebsd.org, "re@FreeBSD.org Engineering Team" <re@freebsd.org> Subject: [RFC] Making mount_nfs to attempt NFSv4 before NFSv3 and NFSv2? Message-ID: <dc6de81f-ce20-a772-18b6-d94a3aea97e1@delphij.net>
next in thread | raw e-mail | index | archive | help
This is a multi-part message in MIME format.
--------------emBi8ePUfEbKBsuUI3TW0MQo
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Hi,
Currently, mount_nfs will attempt to use NFSv3 and fallback to NFSv2.
The manual page says:
nfsv2 Use the NFS Version 2 protocol (the default is to try
version 3 first then version 2). Note that NFS version 2
has a file size limit of 2 gigabytes.
And the code agrees, too:
%%%%%%%%
if (trymntmode == V4) {
nfsvers = 4;
mntvers = 3; /* Workaround for GCC. */
} else if (trymntmode == V2) {
nfsvers = 2;
mntvers = 1;
} else {
nfsvers = 3;
mntvers = 3;
}
%%%%%%%%
When trymntmode == ANY, which is the default, mount_nfs would attempt
NFSv3, and if rpcb_getaddr() returned RPC_PROGVERSMISMATCH, it would try
again with trymntmode = V2.
Nowadays, it seems that NFSv4 is becoming more and more popular. If a
server is providing only NFSv4 service, when mounting without -o nfsv4,
the user would receive message like:
RPCPROG_MNT: RPC:Timed out
A friend of mine who is using TrueNAS core hit this yesterday and his
Linux client worked just fine. It took me some time to figure out that
the root cause. It seems that modern Linux distributions have been
using NFSv4 by default for some time.
So I think it makes sense to teach mount_nfs to attempt NFSv4, then
NFSv3 and NFSv2. However, this might be a POLA violation and we would
like to know if there is any objections.
(I've attached a patch but I haven't actually tested it yet).
Cheers,
--------------emBi8ePUfEbKBsuUI3TW0MQo
Content-Type: text/x-patch; charset=UTF-8;
name="0001-mount_nfs-Attempt-NFSv4-before-NFSv3-and-NFSv2.patch"
Content-Disposition: attachment;
filename*0="0001-mount_nfs-Attempt-NFSv4-before-NFSv3-and-NFSv2.patch"
Content-Transfer-Encoding: base64
RnJvbSBlYjZlNjAyMzNkODQwZDA3MmQwMjgwMzI1Y2EyY2IzNzQ1NWRjMmYxIE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBYaW4gTEkgPGRlbHBoaWpARnJlZUJTRC5vcmc+CkRh
dGU6IE1vbiwgMyBKYW4gMjAyMiAxMDo0ODoxNyAtMDgwMApTdWJqZWN0OiBbUEFUQ0hdIG1v
dW50X25mczogQXR0ZW1wdCBORlN2NCBiZWZvcmUgTkZTdjMgYW5kIE5GU3YyLgoKLS0tCiBz
YmluL21vdW50X25mcy9tb3VudF9uZnMuOCB8ICA2ICsrKy0tLQogc2Jpbi9tb3VudF9uZnMv
bW91bnRfbmZzLmMgfCAyOSArKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLQogMiBmaWxl
cyBjaGFuZ2VkLCAyMyBpbnNlcnRpb25zKCspLCAxMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1n
aXQgYS9zYmluL21vdW50X25mcy9tb3VudF9uZnMuOCBiL3NiaW4vbW91bnRfbmZzL21vdW50
X25mcy44CmluZGV4IDY0OGNiMjEyOGU5MC4uNzQxYjVjMjRhMDgwIDEwMDY0NAotLS0gYS9z
YmluL21vdW50X25mcy9tb3VudF9uZnMuOAorKysgYi9zYmluL21vdW50X25mcy9tb3VudF9u
ZnMuOApAQCAtMjgsNyArMjgsNyBAQAogLlwiCUAoIyltb3VudF9uZnMuOAk4LjMgKEJlcmtl
bGV5KSAzLzI5Lzk1CiAuXCIgJEZyZWVCU0QkCiAuXCIKLS5EZCBKdWx5IDEwLCAyMDIxCisu
RGQgSmFudWFyeSAxMCwgMjAyMgogLkR0IE1PVU5UX05GUyA4CiAuT3MKIC5TaCBOQU1FCkBA
IC0yMTYsOCArMjE2LDggQEAgVGhpcyBvcHRpb24gcmVxdWlyZXMgdGhlCiAuQ20gbmZzdjQK
IG9wdGlvbi4KIC5JdCBDbSBuZnN2MgotVXNlIHRoZSBORlMgVmVyc2lvbiAyIHByb3RvY29s
ICh0aGUgZGVmYXVsdCBpcyB0byB0cnkgdmVyc2lvbiAzIGZpcnN0Ci10aGVuIHZlcnNpb24g
MikuCitVc2UgdGhlIE5GUyBWZXJzaW9uIDIgcHJvdG9jb2wgKHRoZSBkZWZhdWx0IGlzIHRv
IHRyeSB2ZXJzaW9uIDQgZmlyc3QsCit0aGVuIHZlcnNpb24gMywgdGhlbiB2ZXJzaW9uIDIp
LgogTm90ZSB0aGF0IE5GUyB2ZXJzaW9uIDIgaGFzIGEgZmlsZSBzaXplIGxpbWl0IG9mIDIg
Z2lnYWJ5dGVzLgogLkl0IENtIG5mc3YzCiBVc2UgdGhlIE5GUyBWZXJzaW9uIDMgcHJvdG9j
b2wuCmRpZmYgLS1naXQgYS9zYmluL21vdW50X25mcy9tb3VudF9uZnMuYyBiL3NiaW4vbW91
bnRfbmZzL21vdW50X25mcy5jCmluZGV4IGUxZWFmMjA2ZTk4Mi4uZTZkN2UwYWZiZmI3IDEw
MDY0NAotLS0gYS9zYmluL21vdW50X25mcy9tb3VudF9uZnMuYworKysgYi9zYmluL21vdW50
X25mcy9tb3VudF9uZnMuYwpAQCAtMTI1LDYgKzEyNSw3IEBAIHN0YXRpYyBlbnVtIG1vdW50
bW9kZSB7CiAJQU5ZLAogCVYyLAogCVYzLAorCVYzb3JWMiwKIAlWNAogfSBtb3VudG1vZGUg
PSBBTlk7CiAKQEAgLTc3NywxNSArNzc4LDIxIEBAIG5mc190cnlwcm90byhzdHJ1Y3QgYWRk
cmluZm8gKmFpLCBjaGFyICpob3N0cCwgY2hhciAqc3BlYywgY2hhciAqKmVycnN0ciwKIAl9
CiAKIHRyeWFnYWluOgotCWlmICh0cnltbnRtb2RlID09IFY0KSB7CisJc3dpdGNoICh0cnlt
bnRtb2RlKSB7CisJY2FzZSBWNDoKKwljYXNlIEFOWToKIAkJbmZzdmVycyA9IDQ7CiAJCW1u
dHZlcnMgPSAzOyAvKiBXb3JrYXJvdW5kIGZvciBHQ0MuICovCi0JfSBlbHNlIGlmICh0cnlt
bnRtb2RlID09IFYyKSB7Ci0JCW5mc3ZlcnMgPSAyOwotCQltbnR2ZXJzID0gMTsKLQl9IGVs
c2UgeworCQlicmVhazsKKwljYXNlIFYzb3JWMjoKKwljYXNlIFYzOgogCQluZnN2ZXJzID0g
MzsKIAkJbW50dmVycyA9IDM7CisJCWJyZWFrOworCWNhc2UgVjI6CisJCW5mc3ZlcnMgPSAy
OworCQltbnR2ZXJzID0gMTsKKwkJYnJlYWs7CiAJfQogCiAJaWYgKHBvcnRzcGVjICE9IE5V
TEwpIHsKQEAgLTc5OSwxMCArODA2LDE0IEBAIG5mc190cnlwcm90byhzdHJ1Y3QgYWRkcmlu
Zm8gKmFpLCBjaGFyICpob3N0cCwgY2hhciAqc3BlYywgY2hhciAqKmVycnN0ciwKIAogCQlp
ZiAoIXJwY2JfZ2V0YWRkcihORlNfUFJPR1JBTSwgbmZzdmVycywgbmNvbmYsICZuZnNfbmIs
CiAJCSAgICBob3N0cCkpIHsKLQkJCWlmIChycGNfY3JlYXRlZXJyLmNmX3N0YXQgPT0gUlBD
X1BST0dWRVJTTUlTTUFUQ0ggJiYKLQkJCSAgICB0cnltbnRtb2RlID09IEFOWSkgewotCQkJ
CXRyeW1udG1vZGUgPSBWMjsKLQkJCQlnb3RvIHRyeWFnYWluOworCQkJaWYgKHJwY19jcmVh
dGVlcnIuY2Zfc3RhdCA9PSBSUENfUFJPR1ZFUlNNSVNNQVRDSCkgeworCQkJCWlmICh0cnlt
bnRtb2RlID09IEFOWSkgeworCQkJCQl0cnltbnRtb2RlID0gVjNvclYyOworCQkJCQlnb3Rv
IHRyeWFnYWluOworCQkJCX0gZWxzZSBpZiAodHJ5bW50bW9kZSA9PSBWM29yVjIpIHsKKwkJ
CQkJdHJ5bW50bW9kZSA9IFYyOworCQkJCQlnb3RvIHRyeWFnYWluOworCQkJCX0KIAkJCX0K
IAkJCXNucHJpbnRmKGVycmJ1Ziwgc2l6ZW9mIGVycmJ1ZiwgIlslc10gJXM6JXM6ICVzIiwK
IAkJCSAgICBuZXRpZCwgaG9zdHAsIHNwZWMsCi0tIAoyLjM0LjEKCg==
--------------emBi8ePUfEbKBsuUI3TW0MQo--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?dc6de81f-ce20-a772-18b6-d94a3aea97e1>