Date: Fri, 30 Jan 1998 05:18:02 GMT From: Mikhail Teterin <mi@aldan.algebra.com> To: FreeBSD-gnats-submit@FreeBSD.ORG Subject: ports/5602: bsd.port.mk computing checksum ALWAYS even when not needed Message-ID: <199801300518.FAA15016@aldan.ziplink.net>
next in thread | raw e-mail | index | archive | help
>Number: 5602
>Category: ports
>Synopsis: when files/md5 does not contain a checksum -- do not compute it
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Thu Jan 29 21:20:01 PST 1998
>Last-Modified:
>Originator: Mikhail Teterin
>Organization:
Virtual Estates, Inc.
>Release: FreeBSD 3.0-CURRENT
>Environment:
>Description:
Even when files/md5 says IGNORE, or a checksum is not there,
bsd.port.mk will still compute the checksum, only to discard it
later.
>How-To-Repeat:
>Fix:
The following seems to fix the problem. May not be the best solution
though:
--- /usr/share/mk/bsd.port.mk.orig Sun Jan 11 14:18:57 1998
+++ /usr/share/mk/bsd.port.mk Fri Jan 30 00:07:31 1998
@@ -1375,3 +1375,2 @@
for file in ${_CKSUMFILES}; do \
- CKSUM=`${MD5} < $$file`; \
CKSUM2=`${GREP} "^MD5 ($$file)" ${MD5_FILE} | ${AWK} '{print $$4}'`; \
@@ -1384,3 +1383,3 @@
OK="false"; \
- elif [ "$$CKSUM" = "$$CKSUM2" ]; then \
+ elif [ "`${MD5} < $$file`" = "$$CKSUM2" ]; then \
${ECHO_MSG} ">> Checksum OK for $$file."; \
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199801300518.FAA15016>