Date: Fri, 3 Apr 2015 14:15:50 -0700 From: Garrett Cooper <yaneurabeya@gmail.com> To: Warner Losh <imp@bsdimp.com> Cc: "freebsd-testing@freebsd.org" <freebsd-testing@freebsd.org>, FreeBSD Toolchain <freebsd-toolchain@freebsd.org> Subject: Re: Failed to build rescue with gcc 4.9 Message-ID: <73C7F494-54BD-4E83-B2AD-882D8C3FF11A@gmail.com> In-Reply-To: <04452C2A-FB67-465B-AE33-44ED2109672E@bsdimp.com> References: <CAG=rPVeUQ0mm8JKEWDcdw2trqOrUtDx0pGwm8FqbEzuf9P39rA@mail.gmail.com> <CAG=rPVcfUFme=9BzTHCKtV2bT8ASHX0JPcczp343mjE9=Kfoug@mail.gmail.com> <CAG=rPVeYShPad4KXr1uzczZJ0-_vBytSRArw7wGk_8VZF1vm1A@mail.gmail.com> <2D2191D4-DB6F-4889-9CA9-DFEE495D8302@bsdimp.com> <CAPyFy2DPMRYkH=hYvPCoaoG2e0FEb8CDagQN2_%2BdygRRmtU-ug@mail.gmail.com> <04452C2A-FB67-465B-AE33-44ED2109672E@bsdimp.com>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Apr 3, 2015, at 14:10, Warner Losh <imp@bsdimp.com> wrote: >> >> On Apr 3, 2015, at 2:39 PM, Ed Maste <emaste@freebsd.org> wrote: >> >> On 3 April 2015 at 13:02, Warner Losh <imp@bsdimp.com> wrote: >>> That shows that something in the list is needed. Likely only crunchhide. >>> >>> It doesn’t tell us why we need it, or when we started needing it, or what >>> other conditions we might need it. This information is critical to document >>> so we know when we can stop doing it in the future. I’m extremely reluctant >>> to commit this until we know these details. >> >> Yes, it's crunchide. It was broken prior to r277259: >> >> | crunchide: Correct 64-bit section header offset >> | >> | For 64-bit binaries the Elf_Ehdr e_shoff is at offset 40, not 44. >> | Instead of using an incorrect hardcoded offset, let the compiler >> | figure it out for us with offsetof(). >> | >> | Differential Revision: https://reviews.freebsd.org/D1543 >> >> It's not completely clear to me why we did not encounter this before; >> a comment before the erroneous write states: >> >> /* >> * update the offset of section header table in elf >> * header if needed. >> */ >> >> so I presume something about the object file created by gcc 4.9 causes >> this code to be executed, while builds using the in-tree compiler did >> not. > > Ah Yes! I remember now! We should find the FreeBSD version at that date > and either build it when we’re cross compiling, or rebuild it when we’re > bootstrapping. > > Thanks for finding this Ed. These numbers need to be bumped by 1, but here they are (this also wasn’t backported to stable/8 or stable/9 AFAICT). Cheers! head: $ svn cat -r r277259 ^/head/sys/sys/param.h | grep '#define.*__FreeBSD_version' | awk '{ print $3 }’ 1100054 stable/10: $ svn cat -r 277557 ^/stable/10/sys/sys/param.h | grep '#define.*__FreeBSD_version' | awk '{ print $3 }' 1001506 [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQEcBAEBCgAGBQJVHwMGAAoJEMZr5QU6S73eWZgH/1Jq6wWZ0fS60AmdWgsU9vc7 woAGbiKKWOX7jm/A1Yo8fIg3C00szKBrdOIMN4G9ZGFZg85jfnQwDZHTMPupyRRd lt4XPMNhC2+FW1t+SCe7zTvlFTN1LBnvc20oxEON9MVGHefYMEdMh+gC7DY2fjJs xpCssUGKRKB2JPVs1UzfV+V31QxnKSjAggqd43lr/D82bzrJ7QUKzg3R4252U8IL YW8XE0w/ig5g6twjosrQPon88yPLDnUo6YFHCcDAhjwvCTRAD9Lu0sT9JTAdAYzN dJ9yNQw+CnDwC8faBzLYG6W86jwP9kfSJTnI23iM+xCFSBX/r4ipB0k+Mm5Xwlo= =xRe1 -----END PGP SIGNATURE-----help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?73C7F494-54BD-4E83-B2AD-882D8C3FF11A>