Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 5 Sep 2025 18:42:35 GMT
From:      Warner Losh <imp@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: f53228c4e398 - main - tests/vmm_cred_jail: use require.kmods property instead of ad-hoc checks
Message-ID:  <202509051842.585IgZNx096786@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by imp:

URL: https://cgit.FreeBSD.org/src/commit/?id=f53228c4e398468c71d3ed8a372cc29ccae6a0c1

commit f53228c4e398468c71d3ed8a372cc29ccae6a0c1
Author:     Siva Mahadevan <me@svmhdvn.name>
AuthorDate: 2025-07-21 13:25:26 +0000
Commit:     Warner Losh <imp@FreeBSD.org>
CommitDate: 2025-09-05 18:42:23 +0000

    tests/vmm_cred_jail: use require.kmods property instead of ad-hoc checks
    
    Signed-off-by: Siva Mahadevan <me@svmhdvn.name>
    Sponsored by: The FreeBSD Foundation
    Reviewed by: imp
    Pull Request: https://github.com/freebsd/freebsd-src/pull/1780
---
 tests/sys/vmm/vmm_cred_jail.sh | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/tests/sys/vmm/vmm_cred_jail.sh b/tests/sys/vmm/vmm_cred_jail.sh
index 5b02b5dc0b42..dd7907b15352 100644
--- a/tests/sys/vmm/vmm_cred_jail.sh
+++ b/tests/sys/vmm/vmm_cred_jail.sh
@@ -35,12 +35,10 @@ vmm_cred_jail_host_head()
 {
 	atf_set "descr" "Tests deleting the host's VM from within a jail"
 	atf_set "require.user" "root"
+	atf_set "require.kmods" "vmm"
 }
 vmm_cred_jail_host_body()
 {
-	if ! -c /dev/vmmctl; then
-		atf_skip "vmm is not loaded"
-	fi
 	bhyvectl --vm=testvm --create
 	vmm_mkjail myjail
 	atf_check -s exit:1 -e ignore jexec myjail bhyvectl --vm=testvm --destroy
@@ -56,12 +54,10 @@ vmm_cred_jail_other_head()
 {
 	atf_set "descr" "Tests deleting a jail's VM from within another jail"
 	atf_set "require.user" "root"
+	atf_set "require.kmods" "vmm"
 }
 vmm_cred_jail_other_body()
 {
-	if ! -c /dev/vmmctl; then
-		atf_skip "vmm is not loaded"
-	fi
 	vmm_mkjail myjail1
 	vmm_mkjail myjail2
 	atf_check -s exit:0 jexec myjail1 bhyvectl --vm=testvm --create



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202509051842.585IgZNx096786>