Date: Thu, 8 Jul 2004 21:40:25 GMT From: Rui Lopes <rui@ruilopes.com> To: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/68769: [PATCH] devel/maven: update to 1.0.r4 and MASTER_SITE_APACHE Message-ID: <200407082140.i68LePcT088215@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/68769; it has been noted by GNATS.
From: Rui Lopes <rui@ruilopes.com>
To: herve.quiroz@esil.univ-mrs.fr
Cc: Volker Stolz <vs@freebsd.org>, freebsd-gnats-submit@freebsd.org
Subject: Re: ports/68769: [PATCH] devel/maven: update to 1.0.r4 and MASTER_SITE_APACHE
Date: Thu, 08 Jul 2004 22:37:35 +0100
Hi Volker,
Volker Stolz wrote:
> - Update to 1.0.r4
> - Use ${MASTER_SITE_APACHE}
> - Set and use ${DATADIR} as suggested in [1]
> - ${DISTNAME} is now set according to ${PORTVERSION}
I'm OK with all changes except this one:
> - post-configure -> do-configure
Basically I fell we shouln't override the default targets (the do-XXX)
and only override the pre- and post- ones, this way the port system is
free to have a default action for the do-XXX (maybe not applicable right
now for java ports, but maybe in future it will).
[...]
> To sum up, the first two change items are quite needed (update to
1.0rc4 and
> MASTER_SITE_APACHE) but the last three ones are more cosmetic
changes. Feel
> free to tell me your opinion on the subject and should you disagree with
> something in this PR, I will provide a new patch to match your
suggestions.
>
>
> [1] Porter's handbook - Using Java - Best practices
>
http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/using-java.html#JAVA-BEST-PRACTICES
Nice, we now have a Java section :)
Thanks for updating the port Volker!
Best regards,
Rui Lopes
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200407082140.i68LePcT088215>