Date: Wed, 29 Apr 2015 16:00:08 -0700 From: Garrett Cooper <yaneurabeya@gmail.com> To: Mariusz Zaborski <oshogbo@FreeBSD.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r282252 - head/lib/libcapsicum Message-ID: <8E2140D8-E008-4A9D-A628-1FA4693A8797@gmail.com> In-Reply-To: <201504292219.t3TMJeGn071528@svn.freebsd.org> References: <201504292219.t3TMJeGn071528@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Apr 29, 2015, at 15:19, Mariusz Zaborski <oshogbo@FreeBSD.org> wrote: > Author: oshogbo > Date: Wed Apr 29 22:19:40 2015 > New Revision: 282252 > URL: https://svnweb.freebsd.org/changeset/base/282252 > > Log: > Remove the use of nvlist_.*[vf] functions from libcapsicum and replace > them with snprintf(3). Assert the results of snprintf(3). > > Approved by: pjd (mentor) assert(3) can be compiled out with NDEBUG, causing memory corruption on memory allocation failure or snprintf-related failure. Is using assert a good idea? Thanks! -NGie [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQEcBAEBCgAGBQJVQWJ5AAoJEMZr5QU6S73eS0sH/igysTkAKOzokPcESuDjz+zx 3aE7QVgk8+7JEAManDXrXco7jkp+M8Mf55j3j56qwnNG6IZMc1Kun9KtXC85H2Zh ljSBarufw54W0u3ZGUeX3rd+9YS+0Nysxn2FTMaXHGFKf4GI3e6nB5DLM9yEwWhY BQ0AxiAx75mEPc1I++/ZFDAeRuuXAn+/0aAkZo2Irtmpvq9/GdNbRdTIs+FhFsez u4KLIKkJ1VjDX1YVC72zbbo3ejr8sDfIW2JR9Q6xYwVy3jaz6KCXyVesKYYxRZJi hl9xP/de99LOCxJIM5L83CmG7s/pYzXl49h5Au+ECW8LQ3xAAk25RAFoqS+IRek= =+ewl -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?8E2140D8-E008-4A9D-A628-1FA4693A8797>