Date: Sat, 29 Jul 2000 23:14:22 +0100 From: David Malone <dwmalone@maths.tcd.ie> To: Bosko Milekic <bmilekic@dsuper.net> Cc: David Malone <dwmalone@maths.tcd.ie>, Alfred Perlstein <bright@wintelcom.net>, net@FreeBSD.ORG Subject: Re: Mbuf stuff. Message-ID: <200007292314.aa22039@salmon.maths.tcd.ie> In-Reply-To: Your message of "Sat, 29 Jul 2000 16:56:49 EDT." <Pine.BSF.4.21.0007291652050.6913-100000@jehovah.technokratis.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> > /usr/src/sys/sys/mbuf.h > > > > The call to _MEXTFREE in MFREE is wrapped in braces, which > > I think goes against style(9). > That's up to you, it makes no difference to me. I don't remember > seeing anything specifically _against_ it in style(9) but I'm not sure. It says: "No braces are used for control statements with zero or only a single statement unless that statement is more than a single line in which case they are permitted." > > Should we comment the fact that _MEXTFREE has to be called > > at splimp? > Not really necessary, because it always is called at splimp(), and > it's not the exported macro. The "exported" version of the macro wraps > _MEXTFREE at MBUFLOCK(), and it's called MEXTFREE(). _MEXT_DEALLOC_CNT is also internal, but has an XXX somment saying it should be called at splimp(), which it always is. I just thought it would be more consistant to have a comment for both. > Thank you very much for bringing all this stuff up! Glad to be useful ;-) Do you want to make a new version of the patch available, or should Alfred make the changes as he commits? David. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi? <200007292314.aa22039>