Date: Sat, 19 Apr 2008 12:00:09 GMT From: Marc Fonvieille <blackend@FreeBSD.org> To: freebsd-doc@FreeBSD.org Subject: Re: docs/122906: [patch] Fix makevar, maketarget Tags in Handbook Chapter 4. Message-ID: <200804191200.m3JC08GO071031@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR docs/122906; it has been noted by GNATS. From: Marc Fonvieille <blackend@FreeBSD.org> To: Gabor PALI <pgj@FreeBSD.org> Cc: FreeBSD-gnats-submit@FreeBSD.org Subject: Re: docs/122906: [patch] Fix makevar, maketarget Tags in Handbook Chapter 4. Date: Sat, 19 Apr 2008 13:46:43 +0200 On Sat, Apr 19, 2008 at 12:51:39PM +0200, Gabor PALI wrote: > > >Number: 122906 > >Category: docs > >Synopsis: [patch] Fix makevar, maketarget Tags in Handbook Chapter 4. > >Confidential: no > >Severity: non-critical > >Priority: low > >Responsible: freebsd-doc > >State: open > >Quarter: > >Keywords: > >Date-Required: > >Class: doc-bug > >Submitter-Id: current-users > >Arrival-Date: Sat Apr 19 11:00:01 UTC 2008 > >Closed-Date: > >Last-Modified: > >Originator: Gabor PALI > >Release: FreeBSD 6.3-STABLE i386 > >Organization: > >Environment: > System: FreeBSD disznohal 6.3-STABLE FreeBSD 6.3-STABLE #4: Fri Apr 4 23:29:43 CEST 2008 dezzy@disznohal:/usr/obj/usr/src/sys/GENERIC_ i386 > > >Description: > I found a small inconsistency in the use of maketarget, makevar > tags in SGML source of the Handbook chapter titled ``Packages and > Ports''. So, I created a patch to unify their usage and > <command>make <maketarget>all consistent</maketarget></command> > in the <makevar>PORTS_CHAPTER</makevar> :) > > > --- ports.patch.diff begins here --- [...] Hello, This patch mixes content and whitespace/wrapline changes. We use to not commit changes to the content at the same time as changes to the layout. These changes must be done in 2 separated patches, well most of time we don't do the formatting changes or only when the file starts to be a mess. To come back to the content, the changes seem Ok for me but please send a content changes only patch. -- Marc
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200804191200.m3JC08GO071031>