Date: Thu, 6 Jun 2024 09:20:26 +0200 From: Michael Osipov <michaelo@FreeBSD.org> To: Enji Cooper <yaneurabeya@gmail.com> Cc: "src-committers@freebsd.org" <src-committers@FreeBSD.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@FreeBSD.org>, "dev-commits-src-branches@freebsd.org" <dev-commits-src-branches@FreeBSD.org> Subject: Re: git: 0e0919db966a - stable/14 - periodic.conf: remove long deprecated security_daily_compat_var() Message-ID: <f8213280-dc94-4064-b736-eca66ccd1a78@FreeBSD.org> In-Reply-To: <1B22E11F-D498-4F67-8AE9-AB8D6206F09F@gmail.com> References: <202406050807.455871md091767@gitrepo.freebsd.org> <1B22E11F-D498-4F67-8AE9-AB8D6206F09F@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2024-06-05 17:55, Enji Cooper wrote: > >> On Jun 5, 2024, at 1:07 AM, Michael Osipov <michaelo@FreeBSD.org> wrote: >> >> The branch stable/14 has been updated by michaelo: >> >> URL: https://cgit.FreeBSD.org/src/commit/?id=0e0919db966a83efc696d19b39a5962500e6ad46 >> >> commit 0e0919db966a83efc696d19b39a5962500e6ad46 >> Author: Michael Osipov <michaelo@FreeBSD.org> >> AuthorDate: 2024-04-15 11:05:17 +0000 >> Commit: Michael Osipov <michaelo@FreeBSD.org> >> CommitDate: 2024-06-05 08:05:54 +0000 >> >> periodic.conf: remove long deprecated security_daily_compat_var() >> >> This function is documented to be gone in after 11. Time to remove this >> compat shim. >> >> PR: 275296 >> Reviewed by: jrm (mentor) >> MFC after: 1 month >> Differential Revision: https://reviews.freebsd.org/D44796 >> >> (cherry picked from commit aa48259f337100e79933d660fec8856371f761ed) > > It’s kind of unfortunate that this didn’t just break periodic for folks that rely on these compat variables prior to their removal. Enji, we talked about this with Baptiste a couple of weeks ago. He fixed pkg and deep-analyzed all ports for possible issues. All clean and we so no issue backporting it. Also the removed function has been issuing a warning on every call, did you miss it? Michael
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?f8213280-dc94-4064-b736-eca66ccd1a78>