Date: Fri, 3 Nov 2017 14:20:35 +0000 From: "Morris, Don" <Don.Morris@dell.com> To: "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: RE: svn commit: r325285 - head/sys/amd64/amd64 Message-ID: <30042B831BE3AF428BC874A8B81B08E989BFC9ED@MX104CL02.corp.emc.com>
next in thread | raw e-mail | index | archive | help
> Modified: head/sys/amd64/amd64/pmap.c
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
> --- head/sys/amd64/amd64/pmap.c Wed Nov 1 16:32:11 2017 (r325284)
> +++ head/sys/amd64/amd64/pmap.c Wed Nov 1 18:06:44 2017 (r325285)
> @@ -2892,8 +2892,8 @@ reclaim_pv_chunk_leave_pmap(pmap_t pmap, pmap_t loc=
ked
> static vm_page_t
> reclaim_pv_chunk(pmap_t locked_pmap, struct rwlock **lockp)
> {
> - struct pv_chunk *pc, *pc_marker;
> - struct pv_chunk_header pc_marker_b;
> + struct pv_chunk *pc, *pc_marker, *pc_marker_end;
> + struct pv_chunk_header pc_marker_b, pc_marker_end_b;
> struct md_page *pvh;
> pd_entry_t *pde;
> pmap_t next_pmap, pmap;
> @@ -2906,6 +2906,7 @@ reclaim_pv_chunk(pmap_t locked_pmap, struct rwlock =
**l
> uint64_t inuse;
> int bit, field, freed;
> bool start_di;
> + static int active_reclaims =3D 0;
>=20
> PMAP_LOCK_ASSERT(locked_pmap, MA_OWNED);
> KASSERT(lockp !=3D NULL, ("reclaim_pv_chunk: lockp is NULL"));
> @@ -2914,7 +2915,9 @@ reclaim_pv_chunk(pmap_t locked_pmap, struct rwlock =
**l
> PG_G =3D PG_A =3D PG_M =3D PG_RW =3D 0;
> SLIST_INIT(&free);
> bzero(&pc_marker_b, sizeof(pc_marker_b));
> + bzero(&pc_marker_end, sizeof(pc_marker_end));
> pc_marker =3D (struct pv_chunk *)&pc_marker_b;
> + pc_marker_end =3D (struct pv_chunk *)&pc_marker_end_b;
Shouldn't the additional bzero here be of pc_marker_end_b, not pc_marker_en=
d? Minor bug -- but just saying...
Don Morris
(Statements are not those of my employer, etc, etc...)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?30042B831BE3AF428BC874A8B81B08E989BFC9ED>