Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 22 Mar 2017 18:27:12 +0000
From:      Alexey Dokuchaev <danfe@FreeBSD.org>
To:        Kirill Ponomarew <krion@FreeBSD.org>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r436712 - in head/net/zerotier: . files
Message-ID:  <20170322182712.GA96503@FreeBSD.org>
In-Reply-To: <201703221812.v2MICvxf040839@repo.freebsd.org>
References:  <201703221812.v2MICvxf040839@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Mar 22, 2017 at 06:12:57PM +0000, Kirill Ponomarew wrote:
> New Revision: 436712
> URL: https://svnweb.freebsd.org/changeset/ports/436712
> 
> Log:
>   Update net/zerotier to 1.2.2
>   
>   PR:		217838
>   Submitted by:	dch@skunkwerks.at
>   Approved by:	mat (mentor)
> [...]
>  
> -MAINTAINER=	corsmith@gmail.com
> +MAINTAINER=	dch@skunkwerks.at

This part was not reflected in the log.

> -USES=		gmake
> +USES=		gmake compiler:c11

Nor was this one.

> +GH_ACCOUNT=	zerotier

This is wrong, but I see you've fixed it already.

> -OPTIONS_DEFINE=	CONTROLLER
> -
> -CONTROLLER_DESC=	Network management controller microservice support
> -CONTROLLER_USES=	sqlite
> -CONTROLLER_MAKE_ARGS=	ZT_ENABLE_NETWORK_CONTROLLER=1

Why this part was removed after I've added it just several days ago in
r435612 (see PR 215031)?  If this feature is no longer valid it should
have been reflected in the commit log.  Please do not destroy work of
others without at least giving a sound reason.

./danfe



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170322182712.GA96503>