Date: Tue, 10 Feb 2015 15:59:48 -0700 From: Ian Lepore <ian@freebsd.org> To: Brooks Davis <brooks@freebsd.org> Cc: freebsd-current Current <freebsd-current@freebsd.org>, Michael Gmelin <grembo@freebsd.org>, Peter Wemm <peter@wemm.org>, Marcel Moolenaar <marcel@xcllnt.net> Subject: Re: nagios vs w/uptime Message-ID: <1423609188.80968.29.camel@freebsd.org> In-Reply-To: <20150210225555.GC75249@spindle.one-eyed-alien.net> References: <54DA617A.4090309@wemm.org> <A3904FE0-2D03-4290-B29E-395E8C6F6F96@xcllnt.net> <4A76A371-B573-4E62-BE78-94944963FFD0@freebsd.org> <E36EA56E-3B9E-4C40-B984-E7BE97F0175E@freebsd.org> <1423603964.80968.28.camel@freebsd.org> <20150210225555.GC75249@spindle.one-eyed-alien.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 2015-02-10 at 22:55 +0000, Brooks Davis wrote: > On Tue, Feb 10, 2015 at 02:32:44PM -0700, Ian Lepore wrote: > > On Tue, 2015-02-10 at 22:24 +0100, Michael Gmelin wrote: > > > > > > > > > > On 10 Feb 2015, at 22:17, Michael Gmelin <grembo@freebsd.org> wrote: > > > > > > > > > > > > > > > > > > > >> On 10 Feb 2015, at 21:13, Marcel Moolenaar <marcel@xcllnt.net> wrote: > > > >> > > > >> [Moving to current@] > > > >> > > > >>> On Feb 10, 2015, at 11:52 AM, Peter Wemm <peter@wemm.org> wrote: > > > >>> > > > >>> Surprises: > > > >>> * nagios doesn't like w / uptime anymore. libxo perhaps? > > > >> [...] > > > > > > Adding xo_finish() to w.c line 268 just right before exit(0); fixes that issue (I don't know libxo well enough to say if this is the proper fix or just a workaround, but it seems logical to me). > > > > > > > I wonder if that implies that any non-normal exit from a program that > > has been xo'd will result in the loss of output that would not have been > > lost before the xo changes? That could lead to all kinds of subtle > > failures of existing scripts and apps. > > I suspect that for most programs with more than a few exit points, > adding an atexit() registration to call xo_finish() is going to be a > good odea. > I assume there is some sort of xo_start() call if there's an xo_finish(), so the library could do that for itself? -- Ian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1423609188.80968.29.camel>