Date: Sun, 5 Mar 2017 16:20:48 +0100 From: Baptiste Daroussin <bapt@freebsd.org> To: Julian Elischer <julian@freebsd.org> Cc: rgrimes@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r314693 - head/usr.sbin/rmt Message-ID: <20170305152048.gyilvy7qscqg45hr@ivaldir.net> In-Reply-To: <761e6ecf-89aa-6356-4650-08f3c5c9d6a8@freebsd.org> References: <201703051319.v25DJSGt082916@pdx.rh.CN85.dnsmgr.net> <761e6ecf-89aa-6356-4650-08f3c5c9d6a8@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Sun, Mar 05, 2017 at 11:11:35PM +0800, Julian Elischer wrote: > On 5/3/17 9:19 pm, Rodney W. Grimes wrote: > > -- Start of PGP signed section. > > > On Sun, Mar 05, 2017 at 04:09:18AM +0000, Rodney W. Grimes wrote: > > > > Author: rgrimes > > > > Date: Sun Mar 5 04:09:18 2017 > > > > New Revision: 314693 > > > > URL: https://svnweb.freebsd.org/changeset/base/314693 > > > > > > > > Log: > > > > Change /etc/rmt symlink from absolute to relative path, > > > > correcting the mistake made in r6499 > > > > Approved by: grehan > > > > MFC after: 1 week > > > > > > > > Modified: > > > > head/usr.sbin/rmt/Makefile > > > > > > > > Modified: head/usr.sbin/rmt/Makefile > > > > ============================================================================== > > > > --- head/usr.sbin/rmt/Makefile Sun Mar 5 04:02:47 2017 (r314692) > > > > +++ head/usr.sbin/rmt/Makefile Sun Mar 5 04:09:18 2017 (r314693) > > > > @@ -7,6 +7,6 @@ MAN= rmt.8 > > > > # called from /usr/src/etc/Makefile > > > > etc-rmt: > > > > rm -f ${DESTDIR}/etc/rmt > > > > - ln -s ${BINDIR}/rmt ${DESTDIR}/etc/rmt > > > > + ln -s ..${BINDIR}/rmt ${DESTDIR}/etc/rmt > > > I think this should be ${INSTALL_RSYMLINK} ${BINDIR}/rmt ${DESTDIR}/etc/rmt > > find /usr/src | xargs grep INSTALL_RSYM > > (no results) > > > > Sorry, no prior work does this, perhaps once I get done sweeping the > > absolutes out of the tree (about 10 or 15 IIRC) a pass can be made to > > sweep all ln -s out and propage this internal bsd.lib.mk function out > > to the rest of the source tree? > > > > find /usr/share/mk/ | xargs grep INSTALL_RSYM > > /usr/share/mk/bsd.own.mk:INSTALL_RSYMLINK?= ${INSTALL} ${RSYMLINK} > > /usr/share/mk/bsd.lib.mk: ${INSTALL_RSYMLINK} ${TAG_ARGS:D${TAG_ARGS},development} ${SHLIB_NAME} ${DESTDIR}${_LIBDIR}/${SHLIB_LINK} > > /usr/share/mk/bsd.lib.mk: ${INSTALL_RSYMLINK} ${TAG_ARGS} ${DESTDIR}${_SHLIBDIR}/${SHLIB_NAME} \ > > /usr/share/mk/bsd.lib.mk: ${INSTALL_RSYMLINK} ${TAG_ARGS:D${TAG_ARGS},development} ${DESTDIR}${_SHLIBDIR}/${SHLIB_NAME} \ > > /usr/share/mk/bsd.lib.mk: ${INSTALL_RSYMLINK} ${TAG_ARGS} ${DESTDIR}${_SHLIBDIR}/${SHLIB_NAME} \ > > > > This is called from within bsd.lib.mk only, do we want to use this for > > all symbolics links in the source tree? If so I would of though the > > person adding this functionality to the .mk files would of made > > a tree sweeping looking for that and making those changes as well. > > I've been playing around with libpathconv which converts abs paths to > relative paths etc. > I'w working on the patch to ln to add the -a and -r options that some other > versions have. > > you can specify an absolute path but ln -r (abspath) will generate a > relative link. > my target was the exact absolute symlinks that you are targeting. > > Work commitments have made me lay down tools but this reminds me to pick it > up again. > (libpathconv is in the tree at /lib/libpathconv, but I got interrupted half > way through.. > I'll do the other half.. But install -l rs does exactly that, why adding a new mechanism? and install works with metalog as stated earlier so for the build system it might be better. Which reminds me multiple people have asked you if it won't be a good idea to merge your libpathconv into libutil rather that having a new library for just 2 functions. DSO has a price and you haven't replied, will you consider merging it? Best regards, Bapt [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEgOTj3suS2urGXVU3Y4mL3PG3PloFAli8LMwACgkQY4mL3PG3 PlpC+BAAzrjbq9gfY3hD228mnJgMuhJhrmRnJ5usffY1FxkEDD40O+S5aJIUuKEi 8lU5jCW4wI7B34aTQczH1Sd/Q7zOxl88pxBlL6gJlvPcx++mYFD0cPRpiJqWetms MZsQYc1ENT2QxpSUK8NJNAUhJSV0T85ywunF3tcckQu2nFGCnapUjc8pytFa9RCg TNOL1e7PSS2EPW7A2IpKFq9syQ7L7YQ0+seg1RU8t1f5VYJQ1S+eCic/WAwLT56l RmTt0kj75sQ3+B8gxD7yNt3SHBBJFhnI5LGXIbV3h4KdPXs4gnQstOl+dAUbwuvS FNexpssui827iKhRKz/LtaaRXIjIIBVKyQr7eWtAvtpdFUJuDZx5KTUfRQnZe8iq 6qjLog2iSC3Qwd7BrfCbPKCBFRcoV6rk3s9Q9wCi0YHBGGO/7xBeyvXHesT97ZAp BpMG+2sZqEPS/GihOd4+/Rblf2x+n2KR6ZiJrPZYPz1eKGIi9iIWDGcby3++wjxu uVEOQJhC1GlGVuEi4R3Gu13WmcFpHAaBsxjmtlfC5qVtvDcMosaSxfJ5GTF5+y4m TDZKCpe/auBISZQliE16UOB76oDYIJk3I6UTqnX2si9h1zEzRw27EqEX137I3Z84 ItLoGVYfDZZB8/lzXhKUwjWC8Xpban0kdzFA0+BoTpTOjBlPTBo= =8ugM -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170305152048.gyilvy7qscqg45hr>